RebelCode/rcmod-eddbk-cqrs

View on GitHub

Showing 2 of 2 total issues

Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

        $key,
        $dependencies,
        ConfigFactoryInterface $configFactory,
        ContainerFactoryInterface $containerFactory,
        ContainerFactoryInterface $compContainerFactory,
Severity: Major
Found in src/EddBkCqrsModule.php - About 50 mins to fix

    Avoid variables with short names like $c. Configured minimum length is 3.
    Open

        public function run(ContainerInterface $c = null)
    Severity: Minor
    Found in src/EddBkCqrsModule.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    Severity
    Category
    Status
    Source
    Language