Sign upLogin

RebelCode/rcmod-eddbk-help

View on GitHub
Star

Showing 4 of 4 total issues

Avoid variables with short names like $c. Configured minimum length is 3.
Open

    public function run(ContainerInterface $c = null)
Severity: Minor
Found in src/HelpModule.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        $config,
        $configFactory,
        $containerFactory,
        $compContainerFactory,
        $eventManager,
Severity: Minor
Found in src/HelpModule.php - About 45 mins to fix

    Avoid too many return statements within this method.
    Open

            return substr($pageId, strlen('eddbk-'));
    Severity: Major
    Found in src/GetEddBkPageIdCapableTrait.php - About 30 mins to fix

      Function _getEddBkPageId has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function _getEddBkPageId()
    {
        if (!$this->_wpIsAdmin()) {
            return null;
        }
      Severity: Minor
      Found in src/GetEddBkPageIdCapableTrait.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language