RebelCode/rcmod-eddbk-rest-api

View on GitHub
src/Auth/FilterAuthValidator.php

Summary

Maintainability
A
35 mins
Test Coverage

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        EventManagerInterface $eventManager,
        EventFactoryInterface $eventFactory,
        $eventName,
        $paramKey,
        $paramDefault = false
Severity: Minor
Found in src/Auth/FilterAuthValidator.php - About 35 mins to fix

    The method __construct has a boolean flag argument $paramDefault, which is a certain sign of a Single Responsibility Principle violation.
    Open

            $paramDefault = false
    Severity: Minor
    Found in src/Auth/FilterAuthValidator.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
        public function bar($flag = true) {
        }
    }

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    There are no issues that match your filters.

    Category
    Status