Sign upLogin

RebelCode/rcmod-eddbk-services

View on GitHub
Star

Showing 70 of 70 total issues

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    protected function _wpDeletePost($id)
Severity: Minor
Found in src/Storage/ServicesEntityManager.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $ir. Configured minimum length is 3.
Open

        $ir = [
Severity: Minor
Found in src/Storage/ServicesEntityManager.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $ir. Configured minimum length is 3.
Open

    protected function _updateSchedule($id, $ir)
Severity: Minor
Found in src/Storage/ServicesEntityManager.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    protected function _getPostMeta($id, $metaKey, $default = '')
Severity: Minor
Found in src/Storage/ServicesEntityManager.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    public function delete($id)
Severity: Minor
Found in src/Storage/ServicesEntityManager.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    protected function _getPostMeta($id, $metaKey, $default = '')
Severity: Minor
Found in src/Module/AdminDeleteServiceHandler.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    public function set($id, $entity)
Severity: Minor
Found in src/Storage/ServicesEntityManager.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $id. Configured minimum length is 3.
Open

            $id       = $record['id'];
Severity: Minor
Found in src/Module/SessionTypesMigrationHandler.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $ir. Configured minimum length is 3.
Open

        $ir   = $this->_entityToServiceIr($data);
Severity: Minor
Found in src/Storage/ServicesEntityManager.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        $postType,
        $metaPrefix,
        DeleteCapableInterface $resourcesDeleteRm,
        DeleteCapableInterface $sessionsDeleteRm,
        DeleteCapableInterface $sessionRulesDeleteRm,
Severity: Minor
Found in src/Module/AdminDeleteServiceHandler.php - About 45 mins to fix

    Function _buildWpQueryArgs has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function _buildWpQueryArgs($query = [], $limit = null, $offset = null, $orderBy = null, $desc = false)
    {
        // Get post key field map
        $postKeyMap = $this->_getServicesPostKeyMap();
    Severity: Minor
    Found in src/Storage/ServicesEntityManager.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method query has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function query($query = [], $limit = null, $offset = null, $orderBy = null, $desc = false)
    Severity: Minor
    Found in src/Storage/ServicesEntityManager.php - About 35 mins to fix

      Method _buildWpQueryArgs has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          protected function _buildWpQueryArgs($query = [], $limit = null, $offset = null, $orderBy = null, $desc = false)
      Severity: Minor
      Found in src/Storage/ServicesEntityManager.php - About 35 mins to fix

        Missing class import via use statement (line '53', column '20').
        Open

                return new ArrayIterator($array);
        Severity: Minor
        Found in services.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '63', column '20').
        Open

                return new IteratorIterator($traversable);
        Severity: Minor
        Found in services.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        The method query has a boolean flag argument $desc, which is a certain sign of a Single Responsibility Principle violation.
        Open

            public function query($query = [], $limit = null, $offset = null, $orderBy = null, $desc = false)
        Severity: Minor
        Found in src/Storage/ServicesEntityManager.php by phpmd

        BooleanArgumentFlag

        Since: 1.4.0

        A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

        Example

        class Foo {
    public function bar($flag = true) {
    }
}

        Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

        The method _buildWpQueryArgs has a boolean flag argument $desc, which is a certain sign of a Single Responsibility Principle violation.
        Open

            protected function _buildWpQueryArgs($query = [], $limit = null, $offset = null, $orderBy = null, $desc = false)
        Severity: Minor
        Found in src/Storage/ServicesEntityManager.php by phpmd

        BooleanArgumentFlag

        Since: 1.4.0

        A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

        Example

        class Foo {
    public function bar($flag = true) {
    }
}

        Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

        Avoid using static access to class '\Carbon\Carbon' in method '_processExcludeDate'.
        Open

                $datetime  = Carbon::parse($this->_normalizeString($excludeDate), $timezone);
        Severity: Minor
        Found in src/Storage/ServicesEntityManager.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        The method _getServices() has 131 lines of code. Current threshold is set to 100. Avoid really long methods.
        Open

            protected function _getServices()
    {
        return [
            /**
             * The services manager.
        Severity: Minor
        Found in services.php by phpmd

        The method _updateAvailability uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                    } else {
                // If rule has no ID, insert as a new rule
                $_newRuleIds = $this->rulesInsertRm->insert([$_rule]);
                $_ruleId     = $_newRuleIds[0];
            }
        Severity: Minor
        Found in src/Storage/ServicesEntityManager.php by phpmd

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        Severity
        Category
        Status
        Source
        Language