RebelCode/rcmod-eddbk-services

View on GitHub
services.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method _getServices has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function _getServices()
    {
        return [
            /**
             * The services manager.
Severity: Major
Found in services.php - About 2 hrs to fix

    The method _getServices() has 131 lines of code. Current threshold is set to 100. Avoid really long methods.
    Open

        protected function _getServices()
        {
            return [
                /**
                 * The services manager.
    Severity: Minor
    Found in services.php by phpmd

    Missing class import via use statement (line '53', column '20').
    Open

            return new ArrayIterator($array);
    Severity: Minor
    Found in services.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '63', column '20').
    Open

            return new IteratorIterator($traversable);
    Severity: Minor
    Found in services.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid variables with short names like $c. Configured minimum length is 3.
    Open

                'eddbk_services_manager'                           => function (ContainerInterface $c) {
    Severity: Minor
    Found in services.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    There are no issues that match your filters.

    Category
    Status