RebelCode/rcmod-eddbk-services

View on GitHub
src/Module/AdminDeleteServiceHandler.php

Summary

Maintainability
A
1 hr
Test Coverage

Method __invoke has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __invoke()
    {
        /* @var $event EventInterface */
        $event = func_get_arg(0);

Severity: Minor
Found in src/Module/AdminDeleteServiceHandler.php - About 1 hr to fix

    Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $postType,
            $metaPrefix,
            DeleteCapableInterface $resourcesDeleteRm,
            DeleteCapableInterface $sessionsDeleteRm,
            DeleteCapableInterface $sessionRulesDeleteRm,
    Severity: Minor
    Found in src/Module/AdminDeleteServiceHandler.php - About 45 mins to fix

      Avoid variables with short names like $b. Configured minimum length is 3.
      Open

                  $b = $this->exprBuilder;

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
          private $q = 15; // VIOLATION - Field
          public static function main( array $as ) { // VIOLATION - Formal
              $r = 20 + $this->q; // VIOLATION - Local
              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                  $r += $this->q;
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $id. Configured minimum length is 3.
      Open

          protected function _getPostMeta($id, $metaKey, $default = '')

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
          private $q = 15; // VIOLATION - Field
          public static function main( array $as ) { // VIOLATION - Formal
              $r = 20 + $this->q; // VIOLATION - Local
              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                  $r += $this->q;
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#shortvariable

      There are no issues that match your filters.

      Category
      Status