Sign upLogin

RebelCode/rcmod-eddbk-services

View on GitHub
Star
src/Module/GetEddServicePricesCapableTrait.php

Summary

Maintainability
A
1 hr
Test Coverage

Method _getEddServicePrices has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function _getEddServicePrices($serviceId)
    {
        try {
            $service = $this->_getServicesManager()->get($serviceId);
        } catch (NotFoundExceptionInterface $exception) {
Severity: Minor
Found in src/Module/GetEddServicePricesCapableTrait.php - About 1 hr to fix

    Avoid using short method names like GetEddServicePricesCapableTrait::__(). The configured minimum method name length is 3.
    Open

        abstract protected function __($string, $args = [], $context = null);
    Severity: Minor
    Found in src/Module/GetEddServicePricesCapableTrait.php by phpmd

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
    public function a( $index ) { // Violation
    }
}

    Source https://phpmd.org/rules/naming.html#shortmethodname

    The method __ is not named in camelCase.
    Open

        abstract protected function __($string, $args = [], $context = null);
    Severity: Minor
    Found in src/Module/GetEddServicePricesCapableTrait.php by phpmd

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
    public function get_name() {
    }
}

    Source

    There are no issues that match your filters.

    Category
    Status