Sign upLogin

RebelCode/rcmod-eddbk-session-generator

View on GitHub
Star

Showing 32 of 32 total issues

Method make has 107 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function make($config = null)
    {
        $start       = (int) $this->_containerGet($config, 'start');
        $end         = (int) $this->_containerGet($config, 'end');
        $resourceIds = $this->_containerGet($config, 'resource_ids');
Severity: Major
Found in src/Module/AvailabilityFactory.php - About 4 hrs to fix

    Function _generateForService has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function _generateForService($service)
    {
        // Get the service's schedule availability, since service availability it saved in its schedule
        $scheduleId = $this->_containerGet($service, 'schedule_id');
        $schedule   = $this->resourcesManager->get($scheduleId);
    Severity: Minor
    Found in src/Module/GenerateSessionsHandler.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method _generateForService has 69 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function _generateForService($service)
    {
        // Get the service's schedule availability, since service availability it saved in its schedule
        $scheduleId = $this->_containerGet($service, 'schedule_id');
        $schedule   = $this->resourcesManager->get($scheduleId);
    Severity: Major
    Found in src/Module/GenerateSessionsHandler.php - About 2 hrs to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      <?php

namespace RebelCode\EddBookings\Sessions\Generator;

use ArrayIterator;
      Severity: Major
      Found in src/Generator/WeeklyRepeatingRule.php and 2 other locations - About 1 hr to fix
      src/Generator/DailyRepeatingRule.php on lines 1..52
      src/Generator/YearlyRepeatingRule.php on lines 1..47

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 118.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      <?php

namespace RebelCode\EddBookings\Sessions\Generator;

use Carbon\Carbon;
      Severity: Major
      Found in src/Generator/DailyRepeatingRule.php and 2 other locations - About 1 hr to fix
      src/Generator/WeeklyRepeatingRule.php on lines 1..59
      src/Generator/YearlyRepeatingRule.php on lines 1..47

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 118.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      <?php

namespace RebelCode\EddBookings\Sessions\Generator;

use Carbon\Carbon;
      Severity: Major
      Found in src/Generator/YearlyRepeatingRule.php and 2 other locations - About 1 hr to fix
      src/Generator/DailyRepeatingRule.php on lines 1..52
      src/Generator/WeeklyRepeatingRule.php on lines 1..59

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 118.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Avoid excessively long variable names like $exclusionAvailability. Keep variable name length under 20.
      Open

              $exclusionAvailability = new CompositeAvailability($exclusions);
      Severity: Minor
      Found in src/Module/AvailabilityFactory.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid using short method names like CreatePeriodCapableFactoryTrait::__(). The configured minimum method name length is 3.
      Open

          abstract protected function __($string, $args = [], $context = null);
      Severity: Minor
      Found in src/Time/CreatePeriodCapableFactoryTrait.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like PeriodFactoryAwareTrait::__(). The configured minimum method name length is 3.
      Open

          abstract protected function __($string, $args = [], $context = null);
      Severity: Minor
      Found in src/Time/PeriodFactoryAwareTrait.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Function make has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          public function make($config = null)
    {
        $start       = (int) $this->_containerGet($config, 'start');
        $end         = (int) $this->_containerGet($config, 'end');
        $resourceIds = $this->_containerGet($config, 'resource_ids');
      Severity: Minor
      Found in src/Module/AvailabilityFactory.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              SessionGeneratorInterface $generator,
        EntityManagerInterface $servicesManager,
        GetCapableManagerInterface $resourcesManager,
        FactoryInterface $sessionTypeFactory,
        FactoryInterface $availabilityFactory,
      Severity: Major
      Found in src/Module/GenerateSessionsHandler.php - About 1 hr to fix

        Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                $periodFactory,
        $start,
        $end,
        $repeatFreq = null,
        $repeatEnd = null,
        Severity: Major
        Found in src/Generator/MonthlyRepeatingRule.php - About 50 mins to fix

          Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  $key,
        $dependencies,
        $configFactory,
        $containerFactory,
        $compContainerFactory,
          Severity: Major
          Found in src/Module/EddBkSessionGeneratorModule.php - About 50 mins to fix

            Avoid variables with short names like $id. Configured minimum length is 3.
            Open

                protected function _getPostMeta($id, $metaKey, $default = '')
            Severity: Minor
            Found in src/Module/GenerateSessionsHandler.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $b. Configured minimum length is 3.
            Open

                    $b = $this->exprBuilder;
            Severity: Minor
            Found in src/Module/GenerateSessionsHandler.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $c. Configured minimum length is 3.
            Open

                public function run(ContainerInterface $c = null)
            Severity: Minor
            Found in src/Module/EddBkSessionGeneratorModule.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

            Source https://phpmd.org/rules/naming.html#shortvariable

            Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    $periodFactory,
        $start,
        $end,
        $repeatFreq = null,
        $repeatEnd = null,
            Severity: Minor
            Found in src/Generator/WeeklyRepeatingRule.php - About 45 mins to fix

              Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      $periodFactory,
        $start,
        $end,
        $repeatFreq = null,
        $repeatEnd = null,
              Severity: Minor
              Found in src/Generator/YearlyRepeatingRule.php - About 45 mins to fix

                Method _initRule has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        $periodFactory,
        $start,
        $end,
        $repeatFreq = null,
        $repeatEnd = null,
                Severity: Minor
                Found in src/Generator/AbstractIteratorRule.php - About 45 mins to fix

                  Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          $periodFactory,
        $start,
        $end,
        $repeatFreq = null,
        $repeatEnd = null,
                  Severity: Minor
                  Found in src/Generator/DailyRepeatingRule.php - About 45 mins to fix
                    Severity
                    Category
                    Status
                    Source
                    Language