Sign upLogin

RebelCode/rcmod-wp-bookings-cqrs

View on GitHub
Star
src/ResourcesEntityManager.php

Summary

Maintainability
C
1 day
Test Coverage

File ResourcesEntityManager.php has 311 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace RebelCode\Storage\Resource\WordPress;

use ArrayAccess;
Severity: Minor
Found in src/ResourcesEntityManager.php - About 3 hrs to fix

    ResourcesEntityManager has 23 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class ResourcesEntityManager extends BaseCqrsEntityManager
{
    /* @since [*next-version*] */
    use ContainerGetPathCapableTrait;
    Severity: Minor
    Found in src/ResourcesEntityManager.php - About 2 hrs to fix

      Method _updateSessionRules has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function _updateSessionRules($id, $data)
    {
        $b = $this->exprBuilder;

        try {
      Severity: Minor
      Found in src/ResourcesEntityManager.php - About 1 hr to fix

        Method __construct has 10 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                SelectCapableInterface $selectRm,
        InsertCapableInterface $insertRm,
        UpdateCapableInterface $updateRm,
        DeleteCapableInterface $deleteRm,
        SelectCapableInterface $rulesSelectRm,
        Severity: Major
        Found in src/ResourcesEntityManager.php - About 1 hr to fix

          Method _processSessionRuleData has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function _processSessionRuleData($resourceId, $ruleData, $serviceTz)
    {
        $allDay = $this->_containerGet($ruleData, 'isAllDay');

        // Parse the service timezone name into a timezone object
          Severity: Minor
          Found in src/ResourcesEntityManager.php - About 1 hr to fix

            Function _updateSessionRules has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function _updateSessionRules($id, $data)
    {
        $b = $this->exprBuilder;

        try {
            Severity: Minor
            Found in src/ResourcesEntityManager.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            The method __construct has 10 parameters. Consider reducing the number of parameters to less than 10.
            Open

                public function __construct(
        SelectCapableInterface $selectRm,
        InsertCapableInterface $insertRm,
        UpdateCapableInterface $updateRm,
        DeleteCapableInterface $deleteRm,
            Severity: Minor
            Found in src/ResourcesEntityManager.php by phpmd

            The method _updateSessionRules uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                        } else {
                // If rule has an ID, update the existing rule
                $_ruleExp = $b->eq(
                    $b->var('id'),
                    $b->lit($_ruleId)
            Severity: Minor
            Found in src/ResourcesEntityManager.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            Avoid variables with short names like $id. Configured minimum length is 3.
            Open

                protected function _createResourceIdExpression($id)
            Severity: Minor
            Found in src/ResourcesEntityManager.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $b. Configured minimum length is 3.
            Open

                        $b = $this->exprBuilder;
            Severity: Minor
            Found in src/ResourcesEntityManager.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $id. Configured minimum length is 3.
            Open

                public function set($id, $entity)
            Severity: Minor
            Found in src/ResourcesEntityManager.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $b. Configured minimum length is 3.
            Open

                    $b = $this->exprBuilder;
            Severity: Minor
            Found in src/ResourcesEntityManager.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $id. Configured minimum length is 3.
            Open

                    $id = parent::add($entity);
            Severity: Minor
            Found in src/ResourcesEntityManager.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $id. Configured minimum length is 3.
            Open

                public function update($id, $data)
            Severity: Minor
            Found in src/ResourcesEntityManager.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $e. Configured minimum length is 3.
            Open

                    $record = array_map($fn = function ($e) use (&$fn) {
            Severity: Minor
            Found in src/ResourcesEntityManager.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $id. Configured minimum length is 3.
            Open

                public function delete($id)
            Severity: Minor
            Found in src/ResourcesEntityManager.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $id. Configured minimum length is 3.
            Open

                protected function _wpGetImageUrl($id)
            Severity: Minor
            Found in src/ResourcesEntityManager.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $fn. Configured minimum length is 3.
            Open

                    $record = array_map($fn = function ($e) use (&$fn) {
            Severity: Minor
            Found in src/ResourcesEntityManager.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $id. Configured minimum length is 3.
            Open

                protected function _updateSessionRules($id, $data)
            Severity: Minor
            Found in src/ResourcesEntityManager.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

            Source https://phpmd.org/rules/naming.html#shortvariable

            There are no issues that match your filters.

            Category
            Status