Sign upLogin

RebelCode/rcmod-wp-bookings-shortcode

View on GitHub
Star

Showing 4 of 4 total issues

Avoid excessively long variable names like $servicesEntityManager. Keep variable name length under 20.
Open

    private $servicesEntityManager;
Severity: Minor
Found in src/Handlers/ShortcodeParametersTransformHandler.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $servicesEntityManager. Keep variable name length under 20.
Open

    public function __construct($cartPageId, $servicesEntityManager, $serviceTransformer)
Severity: Minor
Found in src/Handlers/ShortcodeParametersTransformHandler.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

        $key,
        $dependencies,
        $configFactory,
        $containerFactory,
        $compContainerFactory,
Severity: Major
Found in src/WpBookingsShortcode.php - About 50 mins to fix

    Avoid variables with short names like $c. Configured minimum length is 3.
    Open

        public function run(ContainerInterface $c = null)
    Severity: Minor
    Found in src/WpBookingsShortcode.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Severity
    Category
    Status
    Source
    Language