Sign upLogin

RebelCode/rcmod-wp-bookings-ui

View on GitHub
Star
src/WpBookingsUiModule.php

Summary

Maintainability
D
1 day
Test Coverage

File WpBookingsUiModule.php has 291 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace RebelCode\Bookings\WordPress\Module;

use Dhii\Data\Container\ContainerFactoryInterface;
Severity: Minor
Found in src/WpBookingsUiModule.php - About 3 hrs to fix

    Method _adminMenu has 72 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function _adminMenu($c)
    {
        $rootMenuConfig         = $c->get('wp_bookings_ui/menu/root');
        $servicesMenuConfig     = $c->get('wp_bookings_ui/menu/services');
        $staffMembersMenuConfig = $c->get('wp_bookings_ui/menu/staff_members');
    Severity: Major
    Found in src/WpBookingsUiModule.php - About 2 hrs to fix

      Method _enqueueAssets has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function _enqueueAssets(ContainerInterface $assetsUrlMap, ContainerInterface $c)
    {
        if (!$this->_isOnAppPage()) {
            return;
        }
      Severity: Minor
      Found in src/WpBookingsUiModule.php - About 1 hr to fix

        Function _enqueueAssets has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function _enqueueAssets(ContainerInterface $assetsUrlMap, ContainerInterface $c)
    {
        if (!$this->_isOnAppPage()) {
            return;
        }
        Severity: Minor
        Found in src/WpBookingsUiModule.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                $key,
        $dependencies,
        $configFactory,
        $containerFactory,
        $compContainerFactory,
        Severity: Major
        Found in src/WpBookingsUiModule.php - About 50 mins to fix

          Function _prepareEndpoints has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function _prepareEndpoints($endpointsConfig)
    {
        $resultingConfig = [];

        foreach ($endpointsConfig as $namespace => $endpoints) {
          Severity: Minor
          Found in src/WpBookingsUiModule.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  $this->staffMembersPageId = add_submenu_page(
            $rootMenuConfig->get('menu_slug'),
            $this->__($staffMembersMenuConfig->get('page_title')),
            $this->__($staffMembersMenuConfig->get('menu_title')),
            $staffMembersMenuConfig->get('capability'),
          Severity: Major
          Found in src/WpBookingsUiModule.php and 1 other location - About 2 hrs to fix
          src/WpBookingsUiModule.php on lines 468..482

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 121.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  $this->servicesPageId = add_submenu_page(
            $rootMenuConfig->get('menu_slug'),
            $this->__($servicesMenuConfig->get('page_title')),
            $this->__($servicesMenuConfig->get('menu_title')),
            $servicesMenuConfig->get('capability'),
          Severity: Major
          Found in src/WpBookingsUiModule.php and 1 other location - About 2 hrs to fix
          src/WpBookingsUiModule.php on lines 484..498

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 121.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Avoid excessively long variable names like $wizardSettingsTabContent. Keep variable name length under 20.
          Open

                          $wizardSettingsTabContent = $c->get('eddbk_ui_settings_wizard_tab_template')->render();
          Severity: Minor
          Found in src/WpBookingsUiModule.php by phpmd

          LongVariable

          Since: 0.2

          Detects when a field, formal or local variable is declared with a long name.

          Example

          class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

          Source https://phpmd.org/rules/naming.html#longvariable

          Avoid excessively long variable names like $generalSettingsTabContent. Keep variable name length under 20.
          Open

                          $generalSettingsTabContent = $c->get('eddbk_ui_settings_general_tab_template')->render();
          Severity: Minor
          Found in src/WpBookingsUiModule.php by phpmd

          LongVariable

          Since: 0.2

          Detects when a field, formal or local variable is declared with a long name.

          Example

          class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

          Source https://phpmd.org/rules/naming.html#longvariable

          Avoid excessively long variable names like $staffMembersMenuConfig. Keep variable name length under 20.
          Open

                  $staffMembersMenuConfig = $c->get('wp_bookings_ui/menu/staff_members');
          Severity: Minor
          Found in src/WpBookingsUiModule.php by phpmd

          LongVariable

          Since: 0.2

          Detects when a field, formal or local variable is declared with a long name.

          Example

          class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

          Source https://phpmd.org/rules/naming.html#longvariable

          Avoid variables with short names like $c. Configured minimum length is 3.
          Open

              protected function _getBookingsAppState($c)
          Severity: Minor
          Found in src/WpBookingsUiModule.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $c. Configured minimum length is 3.
          Open

              protected function _renderAboutPage($c)
          Severity: Minor
          Found in src/WpBookingsUiModule.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $c. Configured minimum length is 3.
          Open

              protected function _enqueueAssets(ContainerInterface $assetsUrlMap, ContainerInterface $c)
          Severity: Minor
          Found in src/WpBookingsUiModule.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $c. Configured minimum length is 3.
          Open

              protected function _adminMenu($c)
          Severity: Minor
          Found in src/WpBookingsUiModule.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $c. Configured minimum length is 3.
          Open

              public function run(ContainerInterface $c = null)
          Severity: Minor
          Found in src/WpBookingsUiModule.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $c. Configured minimum length is 3.
          Open

              protected function _getServicesListAppState($c)
          Severity: Minor
          Found in src/WpBookingsUiModule.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $c. Configured minimum length is 3.
          Open

              protected function _getStaffMembersAppState($c)
          Severity: Minor
          Found in src/WpBookingsUiModule.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          There are no issues that match your filters.

          Category
          Status