Sign upLogin

RebelCode/sql-cqrs-resource-models-abstract

View on GitHub
Star

Showing 44 of 44 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace RebelCode\Storage\Resource\Sql;

use Dhii\Util\String\StringableInterface as Stringable;
Severity: Major
Found in src/BuildSqlLimitCapableTrait.php and 1 other location - About 3 hrs to fix
src/BuildSqlOffsetCapableTrait.php on lines 1..93

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 159.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace RebelCode\Storage\Resource\Sql;

use Dhii\Util\String\StringableInterface as Stringable;
Severity: Major
Found in src/BuildSqlOffsetCapableTrait.php and 1 other location - About 3 hrs to fix
src/BuildSqlLimitCapableTrait.php on lines 1..93

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 159.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid excessively long variable names like $sqlExpressionTemplate. Keep variable name length under 20.
Open

    protected function _setSqlExpressionTemplate($sqlExpressionTemplate)
Severity: Minor
Found in src/SqlExpressionTemplateAwareTrait.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $invalidArgumentException. Keep variable name length under 20.
Open

            } catch (InvalidArgumentException $invalidArgumentException) {
Severity: Minor
Found in src/BuildSqlOrderByCapableTrait.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Method _buildSqlOrderBy has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function _buildSqlOrderBy($ordering)
    {
        $orderParts = [];

        foreach ($ordering as $_order) {
Severity: Minor
Found in src/BuildSqlOrderByCapableTrait.php - About 1 hr to fix

    Method _buildSelectSql has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function _buildSelectSql(
        $columns,
        $tables,
        $joins = [],
        LogicalExpressionInterface $where = null,
    Severity: Minor
    Found in src/BuildSelectSqlCapableTrait.php - About 1 hr to fix

      Avoid using short method names like BuildSqlGroupByClauseCapableTrait::__(). The configured minimum method name length is 3.
      Open

          abstract protected function __($string, $args = [], $context = null);
      Severity: Minor
      Found in src/BuildSqlGroupByClauseCapableTrait.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like BuildSelectSqlCapableTrait::__(). The configured minimum method name length is 3.
      Open

          abstract protected function __($string, $args = [], $context = null);
      Severity: Minor
      Found in src/BuildSelectSqlCapableTrait.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like RenderSqlExpressionCapableTrait::__(). The configured minimum method name length is 3.
      Open

          abstract protected function __($string, $args = [], $context = null);
      Severity: Minor
      Found in src/RenderSqlExpressionCapableTrait.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like SqlTableAwareTrait::__(). The configured minimum method name length is 3.
      Open

          abstract protected function __($string, $args = [], $context = null);
      Severity: Minor
      Found in src/SqlTableAwareTrait.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like BuildSqlOffsetCapableTrait::__(). The configured minimum method name length is 3.
      Open

          abstract protected function __($string, $args = [], $context = null);
      Severity: Minor
      Found in src/BuildSqlOffsetCapableTrait.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like BuildInsertSqlCapableTrait::__(). The configured minimum method name length is 3.
      Open

          abstract protected function __($string, $args = [], $context = null);
      Severity: Minor
      Found in src/BuildInsertSqlCapableTrait.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like GetSqlColumnNameCapableContainerTrait::__(). The configured minimum method name length is 3.
      Open

          abstract protected function __($string, $args = [], $context = null);
      Severity: Minor
      Found in src/GetSqlColumnNameCapableContainerTrait.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like SqlExpressionTemplateAwareTrait::__(). The configured minimum method name length is 3.
      Open

          abstract protected function __($string, $args = [], $context = null);
      Severity: Minor
      Found in src/SqlExpressionTemplateAwareTrait.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like BuildSqlOrderByCapableTrait::__(). The configured minimum method name length is 3.
      Open

          abstract protected function __($string, $args = [], $context = null);
      Severity: Minor
      Found in src/BuildSqlOrderByCapableTrait.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like EscapeSqlReferenceCapableTrait::__(). The configured minimum method name length is 3.
      Open

          abstract protected function __($string, $args = [], $context = null);
      Severity: Minor
      Found in src/EscapeSqlReferenceCapableTrait.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like NormalizeSqlValueCapableTrait::__(). The configured minimum method name length is 3.
      Open

          abstract protected function __($string, $args = [], $context = null);
      Severity: Minor
      Found in src/NormalizeSqlValueCapableTrait.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like BuildUpdateSqlCapableTrait::__(). The configured minimum method name length is 3.
      Open

          abstract protected function __($string, $args = [], $context = null);
      Severity: Minor
      Found in src/BuildUpdateSqlCapableTrait.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like BuildSqlLimitCapableTrait::__(). The configured minimum method name length is 3.
      Open

          abstract protected function __($string, $args = [], $context = null);
      Severity: Minor
      Found in src/BuildSqlLimitCapableTrait.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like SqlFieldColumnMapAwareTrait::__(). The configured minimum method name length is 3.
      Open

          abstract protected function __($string, $args = [], $context = null);
      Severity: Minor
      Found in src/SqlFieldColumnMapAwareTrait.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Severity
      Category
      Status
      Source
      Language