RebelCode/transformers

View on GitHub

Showing 12 of 12 total issues

Avoid excessively long variable names like $invalidArgumentException. Keep variable name length under 20.
Open

            } catch (InvalidArgumentException $invalidArgumentException) {
Severity: Minor
Found in src/MapTransformer.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid using short method names like DelegateTransformerTrait::__(). The configured minimum method name length is 3.
Open

    abstract protected function __($string, $args = [], $context = null);
Severity: Minor
Found in src/DelegateTransformerTrait.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Avoid using short method names like DelegateTransformerContainerTrait::__(). The configured minimum method name length is 3.
Open

    abstract protected function __($string, $args = [], $context = null);

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Avoid using short method names like TransformerAwareTrait::__(). The configured minimum method name length is 3.
Open

    abstract protected function __($string, $args = [], $context = null);
Severity: Minor
Found in src/TransformerAwareTrait.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Method transform has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function transform($source)
    {
        $result = [];

        foreach ($this->_getMapConfig() as $config) {
Severity: Minor
Found in src/MapTransformer.php - About 1 hr to fix

    Method _createCouldNotTransformException has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $message = null,
            $code = null,
            $previous = null,
            $transformer = null,
            $source = null
    Severity: Minor
    Found in src/Exception/CreateCouldNotTransformExceptionCapableTrait.php - About 35 mins to fix

      Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              $message = '',
              $code = 0,
              Throwable $previous = null,
              TransformerInterface $transformer = null,
              $source = null
      Severity: Minor
      Found in src/Exception/CouldNotTransformException.php - About 35 mins to fix

        Function transform has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function transform($source)
            {
                $result = [];
        
                foreach ($this->_getMapConfig() as $config) {
        Severity: Minor
        Found in src/MapTransformer.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid unused parameters such as '$source'.
        Open

                    return function ($value, $source) {
        Severity: Minor
        Found in src/MapTransformer.php by phpmd

        UnusedFormalParameter

        Since: 0.2

        Avoid passing parameters to methods or constructors and then not using those parameters.

        Example

        class Foo
        {
            private function bar($howdy)
            {
                // $howdy is not used
            }
        }

        Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

        The method __ is not named in camelCase.
        Open

            abstract protected function __($string, $args = [], $context = null);
        Severity: Minor
        Found in src/TransformerAwareTrait.php by phpmd

        CamelCaseMethodName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name methods.

        Example

        class ClassName {
            public function get_name() {
            }
        }

        Source

        The method __ is not named in camelCase.
        Open

            abstract protected function __($string, $args = [], $context = null);

        CamelCaseMethodName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name methods.

        Example

        class ClassName {
            public function get_name() {
            }
        }

        Source

        The method __ is not named in camelCase.
        Open

            abstract protected function __($string, $args = [], $context = null);
        Severity: Minor
        Found in src/DelegateTransformerTrait.php by phpmd

        CamelCaseMethodName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name methods.

        Example

        class ClassName {
            public function get_name() {
            }
        }

        Source

        Severity
        Category
        Status
        Source
        Language