Sign upLogin

RebelCode/wp-cqrs-resource-models

View on GitHub
Star
src/Posts/ExtractPostIdsFromExpressionCapableTrait.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method _extractPostIdsFromBetweenExpression has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function _extractPostIdsFromBetweenExpression(LogicalExpressionInterface $expression)
    {
        $isPostIdField = false;
        $pEntity       = $this->_getPostEntityName();
        $pIdField      = $this->_getPostIdFieldName();
Severity: Minor
Found in src/Posts/ExtractPostIdsFromExpressionCapableTrait.php - About 1 hr to fix

    Method _extractPostIdsFromInExpression has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function _extractPostIdsFromInExpression(LogicalExpressionInterface $expression)
    {
        $postIds       = [];
        $isPostIdField = false;
        $pEntity       = $this->_getPostEntityName();
    Severity: Minor
    Found in src/Posts/ExtractPostIdsFromExpressionCapableTrait.php - About 1 hr to fix

      Function _extractPostIdsFromInExpression has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function _extractPostIdsFromInExpression(LogicalExpressionInterface $expression)
    {
        $postIds       = [];
        $isPostIdField = false;
        $pEntity       = $this->_getPostEntityName();
      Severity: Minor
      Found in src/Posts/ExtractPostIdsFromExpressionCapableTrait.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _extractPostIdsFromBetweenExpression has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function _extractPostIdsFromBetweenExpression(LogicalExpressionInterface $expression)
    {
        $isPostIdField = false;
        $pEntity       = $this->_getPostEntityName();
        $pIdField      = $this->_getPostIdFieldName();
      Severity: Minor
      Found in src/Posts/ExtractPostIdsFromExpressionCapableTrait.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _extractPostIdsFromEqualsExpression has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function _extractPostIdsFromEqualsExpression(LogicalExpressionInterface $expression = null)
    {
        $postIds       = [];
        $isPostIdField = false;
        $pEntity       = $this->_getPostEntityName();
      Severity: Minor
      Found in src/Posts/ExtractPostIdsFromExpressionCapableTrait.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid using short method names like ExtractPostIdsFromExpressionCapableTrait::__(). The configured minimum method name length is 3.
      Open

          abstract protected function __($string, $args = [], $context = null);
      Severity: Minor
      Found in src/Posts/ExtractPostIdsFromExpressionCapableTrait.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      The method __ is not named in camelCase.
      Open

          abstract protected function __($string, $args = [], $context = null);
      Severity: Minor
      Found in src/Posts/ExtractPostIdsFromExpressionCapableTrait.php by phpmd

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
    public function get_name() {
    }
}

      Source

      There are no issues that match your filters.

      Category
      Status