RebelCode/wp-cqrs-resource-models

View on GitHub
src/Posts/PostFieldKeyMapAwareTrait.php

Summary

Maintainability
A
35 mins
Test Coverage

Method _mapIterable has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        $iterable,
        $callback,
        $start = null,
        $count = null,
        array &$results = null
Severity: Minor
Found in src/Posts/PostFieldKeyMapAwareTrait.php - About 35 mins to fix

    Avoid using undefined variables such as '$map' which will lead to PHP notices.
    Open

                $this->postFieldKeyMap = $map;

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
    {
        private function bar()
        {
            // $message is undefined
            echo $message;
        }
    }

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$map' which will lead to PHP notices.
    Open

                $this->_mapIterable($postFieldKeyMap, [$this, '_validatePostFieldKeyMapping'], null, null, $map);

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
    {
        private function bar()
        {
            // $message is undefined
            echo $message;
        }
    }

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using short method names like PostFieldKeyMapAwareTrait::__(). The configured minimum method name length is 3.
    Open

        abstract protected function __($string, $args = [], $context = null);

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
        public function a( $index ) { // Violation
        }
    }

    Source https://phpmd.org/rules/naming.html#shortmethodname

    The method __ is not named in camelCase.
    Open

        abstract protected function __($string, $args = [], $context = null);

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
        public function get_name() {
        }
    }

    Source

    There are no issues that match your filters.

    Category
    Status