Sign upLogin

RebelCode/wp-cqrs-resource-models

View on GitHub
Star
src/Wpdb/UpdateCapableWpdbTrait.php

Summary

Maintainability
A
1 hr
Test Coverage

Method _buildUpdateSql has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        $table,
        $changeSet,
        LogicalExpressionInterface $condition = null,
        $ordering = null,
        $limit = null,
Severity: Minor
Found in src/Wpdb/UpdateCapableWpdbTrait.php - About 45 mins to fix

    Function _preProcessChangeSet has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function _preProcessChangeSet($changeSet, &$hashMap = [])
    {
        if ($hashMap === null) {
            $hashMap = [];
        }
    Severity: Minor
    Found in src/Wpdb/UpdateCapableWpdbTrait.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid using undefined variables such as '$hashValueMap' which will lead to PHP notices.
    Open

            $changeSet = $this->_preProcessChangeSet($changeSet, $hashValueMap);
    Severity: Minor
    Found in src/Wpdb/UpdateCapableWpdbTrait.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$hashValueMap' which will lead to PHP notices.
    Open

                $this->_generateWpdbExpressionHashMap($hashValueMap, $condition, $fields);
    Severity: Minor
    Found in src/Wpdb/UpdateCapableWpdbTrait.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$hashValueMap' which will lead to PHP notices.
    Open

            $values = array_values($hashValueMap);
    Severity: Minor
    Found in src/Wpdb/UpdateCapableWpdbTrait.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using short method names like UpdateCapableWpdbTrait::__(). The configured minimum method name length is 3.
    Open

        abstract protected function __($string, $args = [], $context = null);
    Severity: Minor
    Found in src/Wpdb/UpdateCapableWpdbTrait.php by phpmd

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
    public function a( $index ) { // Violation
    }
}

    Source https://phpmd.org/rules/naming.html#shortmethodname

    The method __ is not named in camelCase.
    Open

        abstract protected function __($string, $args = [], $context = null);
    Severity: Minor
    Found in src/Wpdb/UpdateCapableWpdbTrait.php by phpmd

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
    public function get_name() {
    }
}

    Source

    There are no issues that match your filters.

    Category
    Status