Sign upLogin

Restream/redmine_digest

View on GitHub
Star
app/models/digest_event/base.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method format_other_attr has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

  def format_other_attr(val)
    case journal_detail.property
      when 'attr'
        field = journal_detail.prop_key.to_s.gsub(/_id$/, '')
        case journal_detail.prop_key
Severity: Minor
Found in app/models/digest_event/base.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method format_other_attr has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def format_other_attr(val)
    case journal_detail.property
      when 'attr'
        field = journal_detail.prop_key.to_s.gsub(/_id$/, '')
        case journal_detail.prop_key
Severity: Minor
Found in app/models/digest_event/base.rb - About 1 hr to fix

    Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def initialize(event_type, issue_id, created_on, user, journal = nil, journal_detail = nil)
    Severity: Minor
    Found in app/models/digest_event/base.rb - About 45 mins to fix

      Method field_label has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def field_label
    return nil unless journal_detail
    case journal_detail.property
      when 'attr'
        field = journal_detail.prop_key.to_s.gsub(/_id$/, '')
      Severity: Minor
      Found in app/models/digest_event/base.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status