Sign upLogin

Restream/redmine_elasticsearch

View on GitHub
Star

Showing 11 of 11 total issues

Method allowed_to_search_query has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

    def allowed_to_search_query(user, options = {})
      permission = options[:permission] || :search_project
      perm       = Redmine::AccessControl.permission(permission)

      must_queries = []
Severity: Minor
Found in app/models/parent_project.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method allowed_to_search_query has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def allowed_to_search_query(user, options = {})
      permission = options[:permission] || :search_project
      perm       = Redmine::AccessControl.permission(permission)

      must_queries = []
Severity: Major
Found in app/models/parent_project.rb - About 2 hrs to fix

    Method perform_search has 60 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def perform_search(options = {})
        #todo: refactor this
        project_ids = options[:projects] ? [options[:projects]].flatten.compact.map(&:id) : nil

        common_must = []
    Severity: Major
    Found in lib/redmine_elasticsearch/patches/search_controller_patch.rb - About 2 hrs to fix

      Method create_index has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def create_index
        RedmineElasticsearch.client.indices.create(
          index: RedmineElasticsearch::INDEX_NAME,
          body:  {
            settings: {
      Severity: Minor
      Found in lib/redmine_elasticsearch/indexer_service.rb - About 1 hr to fix

        Method index has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def index
        get_variables_from_params

        # quick jump to an issue
        if issue = detect_issue_in_question(@question)
        Severity: Minor
        Found in lib/redmine_elasticsearch/patches/search_controller_patch.rb - About 1 hr to fix

          Method allowed_to_search_query has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def allowed_to_search_query(user, options = {})
      options = options.merge(
        permission: :view_issues,
        type:       'issue'
      )
          Severity: Minor
          Found in app/elastic/issue_search.rb - About 1 hr to fix

            Method get_variables_from_params has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                  def get_variables_from_params
        @question = params[:q] || ''
        @question.strip!
        @all_words          = params[:all_words] ? params[:all_words].present? : true
        @titles_only        = params[:titles_only] ? params[:titles_only].present? : false
            Severity: Minor
            Found in lib/redmine_elasticsearch/patches/search_controller_patch.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method index has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                  def index
        get_variables_from_params

        # quick jump to an issue
        if issue = detect_issue_in_question(@question)
            Severity: Minor
            Found in lib/redmine_elasticsearch/patches/search_controller_patch.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method perform_search has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                  def perform_search(options = {})
        #todo: refactor this
        project_ids = options[:projects] ? [options[:projects]].flatten.compact.map(&:id) : nil

        common_must = []
            Severity: Minor
            Found in lib/redmine_elasticsearch/patches/search_controller_patch.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method prepended has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                  def self.prepended(base)
        base.class_eval do

          # watching for changing size of available_search_types
          class << available_search_types
            Severity: Minor
            Found in lib/redmine_elasticsearch/patches/redmine_search_patch.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method allowed_to_search_query has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def allowed_to_search_query(user, options = {})
      options = options.merge(
        permission: :view_issues,
        type:       'issue'
      )
            Severity: Minor
            Found in app/elastic/issue_search.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language