Sign upLogin

Restream/redmine_non_member_watcher

View on GitHub
Star
lib/redmine_non_member_watcher/patches/user_patch.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method allowed_to_with_non_member_roles? has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def allowed_to_with_non_member_roles?(action, context, options={}, &block)
      allowed_to_without_non_member_roles?(action, context, options, &block) ||
        if logged? && context && context.is_a?(Project)
          roles = roles_for_project(context)
          roles.any? { |role|
Severity: Minor
Found in lib/redmine_non_member_watcher/patches/user_patch.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

        if logged? && context && context.is_a?(Project)
          roles = roles_for_project(context)
          roles.any? { |role|
            (role == Role.non_member_watcher || role == Role.non_member_author) &&
              role.allowed_to?(action) &&
Severity: Major
Found in lib/redmine_non_member_watcher/patches/user_patch.rb - About 40 mins to fix

    There are no issues that match your filters.

    Category
    Status