Sign upLogin

Restream/redmine_role_replacements

View on GitHub
Star

Showing 36 of 36 total issues

Missing top-level module documentation comment.
Open

  module UserPatch
Severity: Minor
Found in lib/redmine_role_replacements/user_patch.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing top-level class documentation comment.
Open

class RoleReplacement < ActiveRecord::Base
Severity: Minor
Found in app/models/role_replacement.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Line is too long. [88/80]
Open

              hash[replacement.role_after] = [] unless hash.key?(replacement.role_after)
Severity: Minor
Found in lib/redmine_role_replacements/user_patch.rb by rubocop

Align the parameters of a method call if they span more than one line.
Open

    param: :project_id,
    after: :settings
Severity: Minor
Found in init.rb by rubocop

Here we check if the parameters on a multi-line method call or definition are aligned.

Example: EnforcedStyle: withfirstparameter (default)

# good

foo :bar,
    :baz

# bad

foo :bar,
  :baz

Example: EnforcedStyle: withfixedindentation

# good

foo :bar,
  :baz

# bad

foo :bar,
    :baz

Line is too long. [86/80]
Open

            roles_before = roles_for_project_without_replacements(replacement.project)
Severity: Minor
Found in lib/redmine_role_replacements/user_patch.rb by rubocop

Missing top-level module documentation comment.
Open

    module InstanceMethods
Severity: Minor
Found in lib/redmine_role_replacements/user_patch.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Space inside parentheses detected.
Open

    super || ( project_id && Project.unscoped.find(project_id) )
Severity: Minor
Found in app/models/role_replacement.rb by rubocop

Checks for spaces inside ordinary round parentheses.

Example:

# bad
f( 3)
g = (a + 3 )

# good
f(3)
g = (a + 3)

Missing top-level class documentation comment.
Open

class RoleReplacementsController < ApplicationController
Severity: Minor
Found in app/controllers/role_replacements_controller.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Use the lambda method for multiline lambdas.
Open

  scope :for_active_projects, -> {
Severity: Minor
Found in app/models/role_replacement.rb by rubocop

This cop (by default) checks for uses of the lambda literal syntax for single line lambdas, and the method call syntax for multiline lambdas. It is configurable to enforce one of the styles for both single line and multiline lambdas as well.

Example: EnforcedStyle: linecountdependent (default)

# bad
f = lambda { |x| x }
f = ->(x) do
      x
    end

# good
f = ->(x) { x }
f = lambda do |x|
      x
    end

Example: EnforcedStyle: lambda

# bad
f = ->(x) { x }
f = ->(x) do
      x
    end

# good
f = lambda { |x| x }
f = lambda do |x|
      x
    end

Example: EnforcedStyle: literal

# bad
f = lambda { |x| x }
f = lambda do |x|
      x
    end

# good
f = ->(x) { x }
f = ->(x) do
      x
    end

Line is too long. [83/80]
Open

            replacement = project.role_replacements.find_by_role_before_id(role.id)
Severity: Minor
Found in lib/redmine_role_replacements/user_patch.rb by rubocop

Align the parameters of a method call if they span more than one line.
Open

      { role_replacements: [:index, :new, :create, :edit, :update, :destroy] },
Severity: Minor
Found in init.rb by rubocop

Here we check if the parameters on a multi-line method call or definition are aligned.

Example: EnforcedStyle: withfirstparameter (default)

# good

foo :bar,
    :baz

# bad

foo :bar,
  :baz

Example: EnforcedStyle: withfixedindentation

# good

foo :bar,
  :baz

# bad

foo :bar,
    :baz

Missing top-level module documentation comment.
Open

  module ProjectPatch
Severity: Minor
Found in lib/redmine_role_replacements/project_patch.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Align the parameters of a method call if they span more than one line.
Open

        notice: l(:message_role_replacements_created)
Severity: Minor
Found in app/controllers/role_replacements_controller.rb by rubocop

Here we check if the parameters on a multi-line method call or definition are aligned.

Example: EnforcedStyle: withfirstparameter (default)

# good

foo :bar,
    :baz

# bad

foo :bar,
  :baz

Example: EnforcedStyle: withfixedindentation

# good

foo :bar,
  :baz

# bad

foo :bar,
    :baz

Align the parameters of a method call if they span more than one line.
Open

    :role_replacements,
Severity: Minor
Found in init.rb by rubocop

Here we check if the parameters on a multi-line method call or definition are aligned.

Example: EnforcedStyle: withfirstparameter (default)

# good

foo :bar,
    :baz

# bad

foo :bar,
  :baz

Example: EnforcedStyle: withfixedindentation

# good

foo :bar,
  :baz

# bad

foo :bar,
    :baz

Line is too long. [86/80]
Open

              hash[replacement.role_before].delete_if { |p| p == replacement.project }
Severity: Minor
Found in lib/redmine_role_replacements/user_patch.rb by rubocop

Line is too long. [95/80]
Open

            if roles_before.include?(replacement.role_before) && replacement.role_after.member?
Severity: Minor
Found in lib/redmine_role_replacements/user_patch.rb by rubocop
Severity
Category
Status
Source
Language