Sign upLogin

Restream/redmine_tagging

View on GitHub
Star

Showing 19 of 19 total issues

Function tagSuggest has 181 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    $.fn.tagSuggest = function (options) {
        var defaults = {
            'matchClass' : 'tagMatches',
            'tagContainer' : 'div',
            'tagWrap' : 'span',
Severity: Major
Found in assets/javascripts/tag.js - About 7 hrs to fix

    Function indexOf has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

        Array.prototype.indexOf = function (searchElement /*, fromIndex */ ) {
        "use strict"
        if (this == null) {
            throw new TypeError()
        }
    Severity: Minor
    Found in assets/javascripts/toggle_tags.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function handleKeys has 60 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                function handleKeys(ev) {
                fromTab = false;
                var type = ev.type;
                var resetSelection = false;
    Severity: Major
    Found in assets/javascripts/tag.js - About 2 hrs to fix

      Method view_layouts_base_content has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

            def view_layouts_base_content(context={})
        return '' if wiki_pages_inline_tags?

        return '' unless context[:controller].is_a?(WikiController)
      Severity: Minor
      Found in lib/tagging_plugin/tagging_hooks.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method view_layouts_base_content has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def view_layouts_base_content(context={})
        return '' if wiki_pages_inline_tags?

        return '' unless context[:controller].is_a?(WikiController)
      Severity: Minor
      Found in lib/tagging_plugin/tagging_hooks.rb - About 1 hr to fix

        Function showSuggestions has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                    function showSuggestions(el, key) {
                workingTags = el.value.split(settings.separator);
                matches = [];
                var i, html = '', chosenTags = {}, tagSelected = false;
        Severity: Minor
        Found in assets/javascripts/tag.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if Redmine::VERSION::MAJOR < 3
      searchable_options[:columns] << "#{IssueTag.table_name}.tag"
      searchable_options[:include] ||= []
      searchable_options[:include] << :issue_tags
    else
          Severity: Major
          Found in lib/redmine_tagging/patches/issue_patch.rb and 1 other location - About 1 hr to fix
          lib/redmine_tagging/patches/wiki_page_patch.rb on lines 17..31

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if Redmine::VERSION::MAJOR < 3
      searchable_options[:columns] << "#{WikiPageTag.table_name}.tag"
      searchable_options[:include] ||= []
      searchable_options[:include] << :wiki_page_tags
    else
          Severity: Major
          Found in lib/redmine_tagging/patches/wiki_page_patch.rb and 1 other location - About 1 hr to fix
          lib/redmine_tagging/patches/issue_patch.rb on lines 22..36

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method tag_cloud_in_project has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def tag_cloud_in_project(project, &each_tag)
    tags = {}

    if project
      context = TaggingPlugin::ContextHelper.context_for(project)
          Severity: Minor
          Found in app/helpers/tagging_helper.rb - About 1 hr to fix

            Function indexOf has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                Array.prototype.indexOf = function (searchElement /*, fromIndex */ ) {
        "use strict"
        if (this == null) {
            throw new TypeError()
        }
            Severity: Minor
            Found in assets/javascripts/toggle_tags.js - About 1 hr to fix

              Method tag_cloud_in_project has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                def tag_cloud_in_project(project, &each_tag)
    tags = {}

    if project
      context = TaggingPlugin::ContextHelper.context_for(project)
              Severity: Minor
              Found in app/helpers/tagging_helper.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method controller_issues_bulk_edit_before_save has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                    def controller_issues_bulk_edit_before_save(context={})
        return if issues_inline_tags? || !has_tags_in_params?(context[:params])

        tags  = context[:params]['issue']['tags'].to_s
        issue = context[:issue]
              Severity: Minor
              Found in lib/tagging_plugin/tagging_hooks.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method sql_for_field_with_tags has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                def sql_for_field_with_tags(field, operator, v, db_table, db_field, is_custom_filter = false)
              Severity: Minor
              Found in lib/redmine_tagging/patches/query_patch.rb - About 45 mins to fix

                Method view_layouts_base_html_head has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                      def view_layouts_base_html_head(context = {})
        tagging_stylesheet = stylesheet_link_tag 'tagging', plugin: 'redmine_tagging'

        unless ((sidebar_tagcloud? &&
          context[:controller].is_a?(WikiController)) ||
                Severity: Minor
                Found in lib/tagging_plugin/tagging_hooks.rb - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid too many return statements within this function.
                Open

                                            return true;
                Severity: Major
                Found in assets/javascripts/tag.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                              return true;
                  Severity: Major
                  Found in assets/javascripts/tag.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                            return true;
                    Severity: Major
                    Found in assets/javascripts/tag.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                              return true;
                      Severity: Major
                      Found in assets/javascripts/tag.js - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                return tags
                        Severity: Major
                        Found in lib/tagging_plugin/tagging_hooks.rb - About 30 mins to fix
                          Severity
                          Category
                          Status
                          Source
                          Language