Sign upLogin

Ricardonacif/active_admin_jcrop

View on GitHub
Star

Showing 5 of 5 total issues

Method minimagick_crop has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def minimagick_crop(img, w, h, x, y)
Severity: Minor
Found in lib/active_admin_jcrop/image_helper.rb - About 35 mins to fix

    Method rmagick_crop has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def rmagick_crop(img, w, h, x, y)
    Severity: Minor
    Found in lib/active_admin_jcrop/image_helper.rb - About 35 mins to fix

      Method crop has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def crop(img, w, h, x, y)
      Severity: Minor
      Found in lib/active_admin_jcrop/image_helper.rb - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    base.register_instance_option(:thumb_method) do
              @thumb_method ||= ((styles = bindings[:object].send(name).styles.keys).find{|k| k.in?([:thumb, :thumbnail, 'thumb', 'thumbnail'])} || styles.first.to_s)
            end
        Severity: Minor
        Found in lib/active_admin_jcrop/asset_engine/paperclip.rb and 1 other location - About 25 mins to fix
        lib/active_admin_jcrop/asset_engine/carrier_wave.rb on lines 48..50

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 29.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    base.register_instance_option(:thumb_method) do
              @thumb_method ||= ((versions = bindings[:object].send(name).versions.keys).find{|k| k.in?([:thumb, :thumbnail, 'thumb', 'thumbnail'])} || versions.first.to_s)
            end
        Severity: Minor
        Found in lib/active_admin_jcrop/asset_engine/carrier_wave.rb and 1 other location - About 25 mins to fix
        lib/active_admin_jcrop/asset_engine/paperclip.rb on lines 71..73

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 29.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language