Sign upLogin

RiotGames/berkshelf

View on GitHub
Star
lib/berkshelf/cached_cookbook.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method pretty_print has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    def pretty_print
      [].tap do |a|
        a.push "        Name: #{cookbook_name}" if name && name =~ /\S/
        a.push "     Version: #{version}" if version && version =~ /\S/
        a.push " Description: #{metadata.description}" if metadata.description && metadata.description =~ /\S/
Severity: Minor
Found in lib/berkshelf/cached_cookbook.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method pretty_hash has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    def pretty_hash
      {}.tap do |h|
        h[:name]          = cookbook_name if cookbook_name && cookbook_name =~ /\S/
        h[:version]       = version if version && version =~ /\S/
        h[:description]   = description if description && description =~ /\S/
Severity: Minor
Found in lib/berkshelf/cached_cookbook.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def validate
      raise IOError, "No Cookbook found at: #{path}" unless path.exist?

      syntax_checker = Chef::Cookbook::SyntaxCheck.new(path.to_path)
Severity: Minor
Found in lib/berkshelf/cached_cookbook.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status