Sign upLogin

RiotGames/vagrant-berkshelf

View on GitHub
Star

Showing 3 of 3 total issues

Method validate has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

      def validate(machine)
        errors = _detected_errors

        if @enabled || @enabled == MAYBE
          # If no Berksfile path was given, check if one is in the working
Severity: Minor
Found in lib/vagrant-berkshelf/config.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method berks has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def berks(command, *args)
        options = args.last.is_a?(Hash) ? args.pop : {}
        args = args.dup

        if options[:berksfile_path]
Severity: Minor
Found in lib/vagrant-berkshelf/helpers.rb - About 1 hr to fix

    Method berks has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

          def berks(command, *args)
        options = args.last.is_a?(Hash) ? args.pop : {}
        args = args.dup

        if options[:berksfile_path]
    Severity: Minor
    Found in lib/vagrant-berkshelf/helpers.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language