Risoluto/Risoluto-Core

View on GitHub
risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php

Summary

Maintainability
D
1 day
Test Coverage

Method test_GenHour_Args2 has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_GenHour_Args2()
    {
        $want = [
            '--' => '',
            '00' => '00',
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php - About 1 hr to fix

Method test_GenHour_Args1 has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_GenHour_Args1()
    {
        $want = [
            '' => '',
            '00' => '00',
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php - About 1 hr to fix

Method test_GenHour_Args4 has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_GenHour_Args4()
    {
        $want = [
            '--' => '--',
            '00' => '午前00',
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php - About 1 hr to fix

Method test_GenHour_Args3 has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_GenHour_Args3()
    {
        $want = [
            '--' => '--',
            '00' => '00',
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php - About 1 hr to fix

Method test_GenHour_NoArgs has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_GenHour_NoArgs()
    {
        $want = [
            '00' => '00',
            '01' => '01',
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php - About 1 hr to fix

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        $want = [
            '--' => '--',
            '00' => '00',
            '01' => '01',
            '02' => '02',
risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php on lines 79..105
risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php on lines 117..143
risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php on lines 193..219

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 133.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        $want = [
            '--' => '--',
            '00' => '午前00',
            '01' => '午前01',
            '02' => '午前02',
risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php on lines 79..105
risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php on lines 117..143
risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php on lines 155..181

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 133.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        $want = [
            '' => '',
            '00' => '00',
            '01' => '01',
            '02' => '02',
risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php on lines 117..143
risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php on lines 155..181
risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php on lines 193..219

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 133.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        $want = [
            '--' => '',
            '00' => '00',
            '01' => '01',
            '02' => '02',
risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php on lines 79..105
risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php on lines 155..181
risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php on lines 193..219

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 133.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status