Sign upLogin

RobertDober/lab42_core

View on GitHub
Star

Showing 7 of 7 total issues

Method Record has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

  def Record(*required, **defaulted)
    Class.new Lab42::Core::RecordImplementation do
      required.each do |req|
        attr_accessor req
      end
Severity: Minor
Found in lib/lab42/core/record.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method __files__ has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  def __files__ selector, glob_para, &blk
    here = pwd
    if blk
      glob( glob_para ).map do | f |
        next if File.directory? f
Severity: Minor
Found in lib/lab42/core/dir.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method limited_value has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def limited_value keys, k, v, valblock, limits
Severity: Minor
Found in lib/lab42/core/meta/hash.rb - About 35 mins to fix

    Method fetch! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def fetch! key, *defaults, &defblk
    default_present = !(defaults.empty? && defblk.nil?)
    return fetch key unless default_present
    fetch key do
      self[ key ] = defblk ? defblk.() : defaults.first
    Severity: Minor
    Found in lib/lab42/core/hash.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      def files glob_para, *rst, &blk
    glob_para = File.join( *glob_para ) if Array === glob_para
    blk = Lab42::Meta::Behavior.behavior *rst, &blk

    __files__ :both, glob_para, &blk
    Severity: Minor
    Found in lib/lab42/core/dir.rb and 2 other locations - About 15 mins to fix
    lib/lab42/core/dir.rb on lines 3..8
    lib/lab42/core/dir.rb on lines 17..22

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      def rel_files glob_para, *rst, &blk
    glob_para = File.join( *glob_para ) if Array === glob_para
    blk = Lab42::Meta::Behavior.behavior *rst, &blk

    __files__ :first, glob_para, &blk
    Severity: Minor
    Found in lib/lab42/core/dir.rb and 2 other locations - About 15 mins to fix
    lib/lab42/core/dir.rb on lines 3..8
    lib/lab42/core/dir.rb on lines 10..15

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      def abs_files glob_para, *rst, &blk
    glob_para = File.join( *glob_para ) if Array === glob_para
    blk = Lab42::Meta::Behavior.behavior *rst, &blk

    __files__ :last, glob_para, &blk
    Severity: Minor
    Found in lib/lab42/core/dir.rb and 2 other locations - About 15 mins to fix
    lib/lab42/core/dir.rb on lines 10..15
    lib/lab42/core/dir.rb on lines 17..22

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Severity
    Category
    Status
    Source
    Language