Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/app/2fa/server/code/index.ts

Summary

Maintainability
B
6 hrs
Test Coverage

Function checkCodeForUser has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

export async function checkCodeForUser({ user, code, method, options = {}, connection }: ICheckCodeForUser): Promise<boolean> {
    if (process.env.TEST_MODE && !options.requireSecondFactor) {
        return true;
    }
Severity: Minor
Found in apps/meteor/app/2fa/server/code/index.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function isAuthorizedForToken has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function isAuthorizedForToken(connection: IMethodConnection, user: IUser, options: ITwoFactorOptions): boolean {
    const currentToken = Accounts._getLoginToken(connection.id);
    const tokenObject = user.services?.resume?.loginTokens?.find((i) => i.hashedToken === currentToken);

    if (!tokenObject) {
Severity: Minor
Found in apps/meteor/app/2fa/server/code/index.ts - About 1 hr to fix

    Function isAuthorizedForToken has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    function isAuthorizedForToken(connection: IMethodConnection, user: IUser, options: ITwoFactorOptions): boolean {
    const currentToken = Accounts._getLoginToken(connection.id);
    const tokenObject = user.services?.resume?.loginTokens?.find((i) => i.hashedToken === currentToken);

    if (!tokenObject) {
    Severity: Minor
    Found in apps/meteor/app/2fa/server/code/index.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

            return true;
    Severity: Major
    Found in apps/meteor/app/2fa/server/code/index.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return false;
      Severity: Major
      Found in apps/meteor/app/2fa/server/code/index.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return false;
        Severity: Major
        Found in apps/meteor/app/2fa/server/code/index.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return true;
          Severity: Major
          Found in apps/meteor/app/2fa/server/code/index.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return false;
            Severity: Major
            Found in apps/meteor/app/2fa/server/code/index.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return true;
              Severity: Major
              Found in apps/meteor/app/2fa/server/code/index.ts - About 30 mins to fix

                There are no issues that match your filters.

                Category
                Status