Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/app/2fa/server/functions/resetTOTP.ts

Summary

Maintainability
B
4 hrs
Test Coverage

Function sendResetNotification has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const sendResetNotification = async function (uid: string): Promise<void> {
    const user = await Users.findOneById<Pick<IUser, 'language' | 'emails'>>(uid, {
        projection: { language: 1, emails: 1 },
    });
    if (!user) {
Severity: Minor
Found in apps/meteor/app/2fa/server/functions/resetTOTP.ts - About 1 hr to fix

    Function sendResetNotification has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    const sendResetNotification = async function (uid: string): Promise<void> {
    const user = await Users.findOneById<Pick<IUser, 'language' | 'emails'>>(uid, {
        projection: { language: 1, emails: 1 },
    });
    if (!user) {
    Severity: Minor
    Found in apps/meteor/app/2fa/server/functions/resetTOTP.ts - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 14 locations. Consider refactoring.
    Open

        const user = await Users.findOneById<Pick<IUser, 'language' | 'emails'>>(uid, {
        projection: { language: 1, emails: 1 },
    });
    Severity: Major
    Found in apps/meteor/app/2fa/server/functions/resetTOTP.ts and 13 other locations - About 1 hr to fix
    apps/meteor/app/livechat/server/lib/Departments.ts on lines 13..15
    apps/meteor/app/livechat/server/methods/searchAgent.ts on lines 33..35
    apps/meteor/ee/app/livechat-enterprise/server/hooks/resumeOnHold.ts on lines 15..17
    apps/meteor/ee/app/livechat-enterprise/server/lib/VisitorInactivityMonitor.ts on lines 77..80
    apps/meteor/ee/app/livechat-enterprise/server/lib/VisitorInactivityMonitor.ts on lines 151..156
    apps/meteor/ee/app/livechat-enterprise/server/methods/resumeOnHold.ts on lines 22..24
    apps/meteor/server/modules/watchers/watchers.module.ts on lines 217..219
    apps/meteor/server/modules/watchers/watchers.module.ts on lines 227..229
    apps/meteor/server/services/team/service.ts on lines 325..325
    apps/meteor/server/services/team/service.ts on lines 398..398
    apps/meteor/server/services/team/service.ts on lines 513..515
    apps/meteor/server/services/team/service.ts on lines 752..754
    apps/meteor/app/api/server/v1/im.ts on lines 416..416

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            try {
            await Mailer.send({
                to: address,
                from,
                subject,
    Severity: Minor
    Found in apps/meteor/app/2fa/server/functions/resetTOTP.ts and 1 other location - About 35 mins to fix
    apps/meteor/server/lib/resetUserE2EKey.ts on lines 36..53

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status