Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/app/api/server/v1/misc.ts

Summary

Maintainability
F
5 days
Test Coverage

File misc.ts has 452 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import crypto from 'crypto';

import type { IUser } from '@rocket.chat/core-typings';
import { Settings, Users } from '@rocket.chat/models';
import {
Severity: Minor
Found in apps/meteor/app/api/server/v1/misc.ts - About 6 hrs to fix

    Function get has 107 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            async get() {
            const { type, icon } = this.queryParams;
            let { channel, name } = this.queryParams;
            if (!settings.get('API_Enable_Shields')) {
                throw new Meteor.Error('error-endpoint-disabled', 'This endpoint is disabled', {
    Severity: Major
    Found in apps/meteor/app/api/server/v1/misc.ts - About 4 hrs to fix

      Function get has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

              async get() {
            const { type, icon } = this.queryParams;
            let { channel, name } = this.queryParams;
            if (!settings.get('API_Enable_Shields')) {
                throw new Meteor.Error('error-endpoint-disabled', 'This endpoint is disabled', {
      Severity: Minor
      Found in apps/meteor/app/api/server/v1/misc.ts - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function post has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              async post() {
            check(this.bodyParams, {
                message: String,
            });
      Severity: Minor
      Found in apps/meteor/app/api/server/v1/misc.ts - About 1 hr to fix

        Function post has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                async post() {
            check(this.bodyParams, {
                message: String,
            });
        Severity: Minor
        Found in apps/meteor/app/api/server/v1/misc.ts - About 1 hr to fix

          Function get has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  async get() {
            const { offset, count } = await getPaginationItems(this.queryParams);
            const { sort, query } = await this.parseJsonQuery();

            const { text, type, workspace = 'local' } = query;
          Severity: Minor
          Found in apps/meteor/app/api/server/v1/misc.ts - About 1 hr to fix

            Function post has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                    async post() {
            check(this.bodyParams, {
                message: String,
            });
            Severity: Minor
            Found in apps/meteor/app/api/server/v1/misc.ts - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function post has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                    async post() {
            check(this.bodyParams, {
                message: String,
            });
            Severity: Minor
            Found in apps/meteor/app/api/server/v1/misc.ts - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        try {
                DDPRateLimiter._increment(rateLimiterInput);
                const rateLimitResult = DDPRateLimiter._check(rateLimiterInput);
                if (!rateLimitResult.allowed) {
                    throw new Meteor.Error('too-many-requests', DDPRateLimiter.getErrorMessage(rateLimitResult), {
            Severity: Major
            Found in apps/meteor/app/api/server/v1/misc.ts and 1 other location - About 1 day to fix
            apps/meteor/app/api/server/v1/misc.ts on lines 610..630

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 265.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        try {
                DDPRateLimiter._increment(rateLimiterInput);

                const rateLimitResult = DDPRateLimiter._check(rateLimiterInput);
                if (!rateLimitResult.allowed) {
            Severity: Major
            Found in apps/meteor/app/api/server/v1/misc.ts and 1 other location - About 1 day to fix
            apps/meteor/app/api/server/v1/misc.ts on lines 555..575

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 265.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status