Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/app/api/server/v1/teams.ts

Summary

Maintainability
D
2 days
Test Coverage

File teams.ts has 565 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { Team } from '@rocket.chat/core-services';
import type { ITeam, UserStatus } from '@rocket.chat/core-typings';
import { TEAM_TYPE } from '@rocket.chat/core-typings';
import { Users, Rooms } from '@rocket.chat/models';
import {
Severity: Major
Found in apps/meteor/app/api/server/v1/teams.ts - About 1 day to fix

    Function get has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            async get() {
            check(
                this.queryParams,
                Match.OneOf(
                    Match.ObjectIncluding({
    Severity: Minor
    Found in apps/meteor/app/api/server/v1/teams.ts - About 1 hr to fix

      Function get has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              async get() {
            check(
                this.queryParams,
                Match.OneOf(
                    Match.ObjectIncluding({
      Severity: Minor
      Found in apps/meteor/app/api/server/v1/teams.ts - About 1 hr to fix

        Function get has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                async get() {
            const { offset, count } = await getPaginationItems(this.queryParams);

            check(
                this.queryParams,
        Severity: Minor
        Found in apps/meteor/app/api/server/v1/teams.ts - About 1 hr to fix

          Function post has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  async post() {
            const { bodyParams } = this;
            const { userId, rooms } = bodyParams;

            const team = await getTeamByIdOrName(this.bodyParams);
          Severity: Minor
          Found in apps/meteor/app/api/server/v1/teams.ts - About 1 hr to fix

            Avoid too many return statements within this function.
            Open

                        return API.v1.success();
            Severity: Major
            Found in apps/meteor/app/api/server/v1/teams.ts - About 30 mins to fix

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                          check(
                this.queryParams,
                Match.ObjectIncluding({
                    filter: Match.Maybe(String),
                    type: Match.Maybe(String),
              Severity: Major
              Found in apps/meteor/app/api/server/v1/teams.ts and 2 other locations - About 1 hr to fix
              apps/meteor/app/api/server/v1/voip/server-connection.ts on lines 31..39
              apps/meteor/ee/server/api/engagementDashboard/channels.ts on lines 43..51

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 73.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                          check(
                this.queryParams,
                Match.OneOf(
                    Match.ObjectIncluding({
                        teamId: String,
              Severity: Major
              Found in apps/meteor/app/api/server/v1/teams.ts and 3 other locations - About 40 mins to fix
              apps/meteor/app/api/server/v1/teams.ts on lines 256..266
              apps/meteor/app/api/server/v1/teams.ts on lines 320..330
              apps/meteor/app/api/server/v1/teams.ts on lines 563..573

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 49.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                          check(
                this.queryParams,
                Match.OneOf(
                    Match.ObjectIncluding({
                        teamId: String,
              Severity: Major
              Found in apps/meteor/app/api/server/v1/teams.ts and 3 other locations - About 40 mins to fix
              apps/meteor/app/api/server/v1/teams.ts on lines 256..266
              apps/meteor/app/api/server/v1/teams.ts on lines 320..330
              apps/meteor/app/api/server/v1/teams.ts on lines 380..390

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 49.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                          check(
                this.queryParams,
                Match.OneOf(
                    Match.ObjectIncluding({
                        teamId: String,
              Severity: Major
              Found in apps/meteor/app/api/server/v1/teams.ts and 3 other locations - About 40 mins to fix
              apps/meteor/app/api/server/v1/teams.ts on lines 320..330
              apps/meteor/app/api/server/v1/teams.ts on lines 380..390
              apps/meteor/app/api/server/v1/teams.ts on lines 563..573

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 49.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                          check(
                this.queryParams,
                Match.OneOf(
                    Match.ObjectIncluding({
                        teamId: String,
              Severity: Major
              Found in apps/meteor/app/api/server/v1/teams.ts and 3 other locations - About 40 mins to fix
              apps/meteor/app/api/server/v1/teams.ts on lines 256..266
              apps/meteor/app/api/server/v1/teams.ts on lines 380..390
              apps/meteor/app/api/server/v1/teams.ts on lines 563..573

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 49.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status