Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/app/crowd/server/crowd.ts

Summary

Maintainability
D
2 days
Test Coverage

File crowd.ts has 349 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import type { IUser } from '@rocket.chat/core-typings';
import { cronJobs } from '@rocket.chat/cron';
import { Users } from '@rocket.chat/models';
import { SHA256 } from '@rocket.chat/sha256';
import AtlassianCrowd from 'atlassian-crowd-patched';
Severity: Minor
Found in apps/meteor/app/crowd/server/crowd.ts - About 4 hrs to fix

    Function sync has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

        async sync() {
        // if crowd is disabled bail out
        if (settings.get('CROWD_Enable') !== true) {
            return;
        }
    Severity: Minor
    Found in apps/meteor/app/crowd/server/crowd.ts - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function authenticate has 64 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        async authenticate(username: string, password: string): Promise<Record<string, any> | undefined> {
        if (!username || !password) {
            logger.error('No username or password');
            return;
        }
    Severity: Major
    Found in apps/meteor/app/crowd/server/crowd.ts - About 2 hrs to fix

      Function authenticate has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

          async authenticate(username: string, password: string): Promise<Record<string, any> | undefined> {
        if (!username || !password) {
            logger.error('No username or password');
            return;
        }
      Severity: Minor
      Found in apps/meteor/app/crowd/server/crowd.ts - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function updateUserCollection has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          async updateUserCollection(crowdUser: Record<string, any>) {
        const username = crowdUser.crowd_username || crowdUser.username;
        const mail = crowdUser.email;

        // If id is not provided, user is linked by crowd_username or email address
      Severity: Minor
      Found in apps/meteor/app/crowd/server/crowd.ts - About 1 hr to fix

        Function sync has 46 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            async sync() {
        // if crowd is disabled bail out
        if (settings.get('CROWD_Enable') !== true) {
            return;
        }
        Severity: Minor
        Found in apps/meteor/app/crowd/server/crowd.ts - About 1 hr to fix

          Function syncDataToUser has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              async syncDataToUser(crowdUser: Record<string, any>, id: string) {
        const user = {
            username: this.cleanUsername(crowdUser.username),
            crowd_username: crowdUser.crowd_username,
            emails: [
          Severity: Minor
          Found in apps/meteor/app/crowd/server/crowd.ts - About 1 hr to fix

            Avoid too many return statements within this function.
            Open

                    return result;
            Severity: Major
            Found in apps/meteor/app/crowd/server/crowd.ts - About 30 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  if (typeof username === 'string') {
        if (username.indexOf('@') === -1) {
            username = { username };
        } else {
            username = { email: username };
              Severity: Major
              Found in apps/meteor/app/crowd/server/crowd.ts and 1 other location - About 1 hr to fix
              apps/meteor/server/lib/ldap/Manager.ts on lines 504..510

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 64.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status