Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/app/file-upload/server/lib/proxy.ts

Summary

Maintainability
B
5 hrs
Test Coverage

Function handle has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

async function handle(req: createServer.IncomingMessage, res: http.ServerResponse, next: NextFunction) {
    // Quick check to see if request should be catch
    if (!req.url?.includes(`/${UploadFS.config.storesPath}/`)) {
        return next();
    }
Severity: Major
Found in apps/meteor/app/file-upload/server/lib/proxy.ts - About 2 hrs to fix

    Function handle has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    async function handle(req: createServer.IncomingMessage, res: http.ServerResponse, next: NextFunction) {
    // Quick check to see if request should be catch
    if (!req.url?.includes(`/${UploadFS.config.storesPath}/`)) {
        return next();
    }
    Severity: Minor
    Found in apps/meteor/app/file-upload/server/lib/proxy.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

            return next();
    Severity: Major
    Found in apps/meteor/app/file-upload/server/lib/proxy.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return;
      Severity: Major
      Found in apps/meteor/app/file-upload/server/lib/proxy.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return;
        Severity: Major
        Found in apps/meteor/app/file-upload/server/lib/proxy.ts - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status