Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/app/integrations/server/lib/validateOutgoingIntegration.ts

Summary

Maintainability
D
2 days
Test Coverage

Function validateOutgoingIntegration has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

export const validateOutgoingIntegration = async function (
    integration: INewOutgoingIntegration | IUpdateOutgoingIntegration,
    userId: IUser['_id'],
): Promise<IOutgoingIntegration> {
    if (integration.channel && Match.test(integration.channel, String) && integration.channel.trim() === '') {
Severity: Minor
Found in apps/meteor/app/integrations/server/lib/validateOutgoingIntegration.ts - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validateOutgoingIntegration has 73 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const validateOutgoingIntegration = async function (
    integration: INewOutgoingIntegration | IUpdateOutgoingIntegration,
    userId: IUser['_id'],
): Promise<IOutgoingIntegration> {
    if (integration.channel && Match.test(integration.channel, String) && integration.channel.trim() === '') {
Severity: Major
Found in apps/meteor/app/integrations/server/lib/validateOutgoingIntegration.ts - About 2 hrs to fix

    Function _verifyUserHasPermissionForChannels has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

    async function _verifyUserHasPermissionForChannels(userId: IUser['_id'], channels: string[]): Promise<void> {
    for await (let channel of channels) {
        if (scopedChannels.includes(channel)) {
            if (channel === 'all_public_channels') {
                // No special permissions needed to add integration to public channels
    Severity: Minor
    Found in apps/meteor/app/integrations/server/lib/validateOutgoingIntegration.ts - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _verifyUserHasPermissionForChannels has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    async function _verifyUserHasPermissionForChannels(userId: IUser['_id'], channels: string[]): Promise<void> {
    for await (let channel of channels) {
        if (scopedChannels.includes(channel)) {
            if (channel === 'all_public_channels') {
                // No special permissions needed to add integration to public channels
    Severity: Minor
    Found in apps/meteor/app/integrations/server/lib/validateOutgoingIntegration.ts - About 1 hr to fix

      Function _verifyRequiredFields has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function _verifyRequiredFields(integration: INewOutgoingIntegration | IUpdateOutgoingIntegration): void {
    if (
        !integration.event ||
        !Match.test(integration.event, String) ||
        integration.event.trim() === '' ||
      Severity: Minor
      Found in apps/meteor/app/integrations/server/lib/validateOutgoingIntegration.ts - About 1 hr to fix

        Function _verifyRequiredFields has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        function _verifyRequiredFields(integration: INewOutgoingIntegration | IUpdateOutgoingIntegration): void {
    if (
        !integration.event ||
        !Match.test(integration.event, String) ||
        integration.event.trim() === '' ||
        Severity: Minor
        Found in apps/meteor/app/integrations/server/lib/validateOutgoingIntegration.ts - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                } else {
            let record;
            const channelType = channel[0];
            channel = channel.substr(1);
        Severity: Major
        Found in apps/meteor/app/integrations/server/lib/validateOutgoingIntegration.ts and 1 other location - About 1 day to fix
        apps/meteor/app/integrations/server/methods/incoming/addIncomingIntegration.ts on lines 123..155

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 224.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            if (
        !isScriptEngineFrozen(integrationData.scriptEngine) &&
        integration.scriptEnabled === true &&
        integration.script &&
        integration.script.trim() !== ''
        Severity: Minor
        Found in apps/meteor/app/integrations/server/lib/validateOutgoingIntegration.ts and 1 other location - About 50 mins to fix
        apps/meteor/app/integrations/server/methods/incoming/addIncomingIntegration.ts on lines 105..121

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                !integration.event ||
        !Match.test(integration.event, String) ||
        integration.event.trim() === '' ||
        Severity: Minor
        Found in apps/meteor/app/integrations/server/lib/validateOutgoingIntegration.ts and 1 other location - About 30 mins to fix
        apps/meteor/app/integrations/server/lib/validateOutgoingIntegration.ts on lines 28..28

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if (!integration.username || !Match.test(integration.username, String) || integration.username.trim() === '') {
        Severity: Minor
        Found in apps/meteor/app/integrations/server/lib/validateOutgoingIntegration.ts and 1 other location - About 30 mins to fix
        apps/meteor/app/integrations/server/lib/validateOutgoingIntegration.ts on lines 18..20

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status