Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/app/integrations/server/methods/incoming/updateIncomingIntegration.ts

Summary

Maintainability
D
2 days
Test Coverage

Function updateIncomingIntegration has 148 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    async updateIncomingIntegration(integrationId, integration) {
        if (!this.userId) {
            throw new Meteor.Error('error-invalid-user', 'Invalid user', {
                method: 'updateOutgoingIntegration',
            });
Severity: Major
Found in apps/meteor/app/integrations/server/methods/incoming/updateIncomingIntegration.ts - About 5 hrs to fix

    Function updateIncomingIntegration has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
    Open

        async updateIncomingIntegration(integrationId, integration) {
        if (!this.userId) {
            throw new Meteor.Error('error-invalid-user', 'Invalid user', {
                method: 'updateOutgoingIntegration',
            });
    Severity: Minor
    Found in apps/meteor/app/integrations/server/methods/incoming/updateIncomingIntegration.ts - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            if (await hasPermissionAsync(this.userId, 'manage-incoming-integrations')) {
            currentIntegration = await Integrations.findOneById(integrationId);
        } else if (await hasPermissionAsync(this.userId, 'manage-own-incoming-integrations')) {
            currentIntegration = await Integrations.findOne({
                '_id': integrationId,
    Severity: Major
    Found in apps/meteor/app/integrations/server/methods/incoming/updateIncomingIntegration.ts and 2 other locations - About 3 hrs to fix
    apps/meteor/app/integrations/server/methods/clearIntegrationHistory.ts on lines 25..36
    apps/meteor/app/integrations/server/methods/outgoing/updateOutgoingIntegration.ts on lines 39..50

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 109.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if (
            integration.script?.trim() &&
            (scriptEngine !== oldScriptEngine || integration.script?.trim() !== currentIntegration.script?.trim())
        ) {
            wrapExceptions(() => validateScriptEngine(scriptEngine)).catch((e) => {
    Severity: Major
    Found in apps/meteor/app/integrations/server/methods/incoming/updateIncomingIntegration.ts and 1 other location - About 3 hrs to fix
    apps/meteor/app/integrations/server/methods/outgoing/updateOutgoingIntegration.ts on lines 58..65

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 99.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

            if (!integration.channel || typeof integration.channel.valueOf() !== 'string' || integration.channel.trim() === '') {
            throw new Meteor.Error('error-invalid-channel', 'Invalid channel', {
                method: 'updateIncomingIntegration',
            });
        }
    Severity: Major
    Found in apps/meteor/app/integrations/server/methods/incoming/updateIncomingIntegration.ts and 5 other locations - About 1 hr to fix
    apps/meteor/app/integrations/server/methods/incoming/addIncomingIntegration.ts on lines 73..77
    apps/meteor/app/oauth2-server-config/server/admin/functions/addOAuthApp.ts on lines 26..28
    apps/meteor/app/oauth2-server-config/server/admin/functions/addOAuthApp.ts on lines 30..38
    apps/meteor/app/oauth2-server-config/server/admin/methods/updateOAuthApp.ts on lines 29..31
    apps/meteor/app/oauth2-server-config/server/admin/methods/updateOAuthApp.ts on lines 33..37

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 72.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            for (const channel of channels) {
            if (!validChannelChars.includes(channel[0])) {
                throw new Meteor.Error('error-invalid-channel-start-with-chars', 'Invalid channel. Start with @ or #', {
                    method: 'updateIncomingIntegration',
                });
    Severity: Minor
    Found in apps/meteor/app/integrations/server/methods/incoming/updateIncomingIntegration.ts and 1 other location - About 55 mins to fix
    apps/meteor/app/integrations/server/methods/incoming/addIncomingIntegration.ts on lines 65..71

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                        await Integrations.updateOne(
                        { _id: integrationId },
                        {
                            $set: {
                                scriptCompiled,
    Severity: Minor
    Found in apps/meteor/app/integrations/server/methods/incoming/updateIncomingIntegration.ts and 1 other location - About 40 mins to fix
    apps/meteor/app/integrations/server/methods/incoming/updateIncomingIntegration.ts on lines 108..118

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                        await Integrations.updateOne(
                        { _id: integrationId },
                        {
                            $set: {
                                scriptError,
    Severity: Minor
    Found in apps/meteor/app/integrations/server/methods/incoming/updateIncomingIntegration.ts and 1 other location - About 40 mins to fix
    apps/meteor/app/integrations/server/methods/incoming/updateIncomingIntegration.ts on lines 93..101

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status