Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/app/livechat/server/api/v1/message.ts

Summary

Maintainability
C
1 day
Test Coverage

File message.ts has 263 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { OmnichannelSourceType } from '@rocket.chat/core-typings';
import { LivechatVisitors, LivechatRooms, Messages } from '@rocket.chat/models';
import { Random } from '@rocket.chat/random';
import {
    isPOSTLivechatMessageParams,
Severity: Minor
Found in apps/meteor/app/livechat/server/api/v1/message.ts - About 2 hrs to fix

    Function post has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            async post() {
            const visitorToken = this.bodyParams.visitor.token;

            const visitor = await LivechatVisitors.getVisitorByToken(visitorToken, {});
            let rid: string;
    Severity: Major
    Found in apps/meteor/app/livechat/server/api/v1/message.ts - About 2 hrs to fix

      Function post has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              async post() {
            const { token, rid, agent, msg } = this.bodyParams;

            const guest = await findGuest(token);
            if (!guest) {
      Severity: Minor
      Found in apps/meteor/app/livechat/server/api/v1/message.ts - About 1 hr to fix

        Function get has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                async get() {
            const { offset } = await getPaginationItems(this.queryParams);
            const { token } = this.queryParams;
            const { rid } = this.urlParams;
        Severity: Minor
        Found in apps/meteor/app/livechat/server/api/v1/message.ts - About 1 hr to fix

          Function put has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  async put() {
            const { token, rid } = this.bodyParams;
            const { _id } = this.urlParams;

            const guest = await findGuest(token);
          Severity: Minor
          Found in apps/meteor/app/livechat/server/api/v1/message.ts - About 1 hr to fix

            Function post has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                    async post() {
            const visitorToken = this.bodyParams.visitor.token;

            const visitor = await LivechatVisitors.getVisitorByToken(visitorToken, {});
            let rid: string;
            Severity: Minor
            Found in apps/meteor/app/livechat/server/api/v1/message.ts - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function post has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                    async post() {
            const { token, rid, agent, msg } = this.bodyParams;

            const guest = await findGuest(token);
            if (!guest) {
            Severity: Minor
            Found in apps/meteor/app/livechat/server/api/v1/message.ts - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function put has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                    async put() {
            const { token, rid } = this.bodyParams;
            const { _id } = this.urlParams;

            const guest = await findGuest(token);
            Severity: Minor
            Found in apps/meteor/app/livechat/server/api/v1/message.ts - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function get has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                    async get() {
            const { offset } = await getPaginationItems(this.queryParams);
            const { token } = this.queryParams;
            const { rid } = this.urlParams;
            Severity: Minor
            Found in apps/meteor/app/livechat/server/api/v1/message.ts - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status