Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/app/livechat/server/hooks/sendToCRM.ts

Summary

Maintainability
D
2 days
Test Coverage

File sendToCRM.ts has 254 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import type { IOmnichannelRoom, IOmnichannelSystemMessage, IMessage } from '@rocket.chat/core-typings';
import { isEditedMessage, isOmnichannelRoom } from '@rocket.chat/core-typings';
import { LivechatRooms, Messages } from '@rocket.chat/models';

import { callbacks } from '../../../../lib/callbacks';
Severity: Minor
Found in apps/meteor/app/livechat/server/hooks/sendToCRM.ts - About 2 hrs to fix

    Function sendToCRM has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

    async function sendToCRM(
    type: CRMActions,
    room: OmnichannelRoomWithExtraFields,
    includeMessages: boolean | IOmnichannelSystemMessage[] = true,
): Promise<OmnichannelRoomWithExtraFields> {
    Severity: Minor
    Found in apps/meteor/app/livechat/server/hooks/sendToCRM.ts - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function sendToCRM has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    async function sendToCRM(
    type: CRMActions,
    room: OmnichannelRoomWithExtraFields,
    includeMessages: boolean | IOmnichannelSystemMessage[] = true,
): Promise<OmnichannelRoomWithExtraFields> {
    Severity: Minor
    Found in apps/meteor/app/livechat/server/hooks/sendToCRM.ts - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

          if (messages) {
        for await (const message of messages) {
            if (message.t && !sendMessageType(message.t)) {
                continue;
            }
      Severity: Critical
      Found in apps/meteor/app/livechat/server/hooks/sendToCRM.ts - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        callbacks.add(
    'livechat.afterForwardChatToAgent',
    async (params) => {
        const { rid, oldServedBy } = params;
        if (!settings.get('Livechat_webhook_on_forward')) {
        Severity: Major
        Found in apps/meteor/app/livechat/server/hooks/sendToCRM.ts and 1 other location - About 4 hrs to fix
        apps/meteor/app/livechat/server/hooks/sendToCRM.ts on lines 228..247

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 130.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        callbacks.add(
    'livechat.afterForwardChatToDepartment',
    async (params) => {
        const { rid, oldDepartmentId } = params;
        if (!settings.get('Livechat_webhook_on_forward')) {
        Severity: Major
        Found in apps/meteor/app/livechat/server/hooks/sendToCRM.ts and 1 other location - About 4 hrs to fix
        apps/meteor/app/livechat/server/hooks/sendToCRM.ts on lines 207..226

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 130.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        callbacks.add(
    'livechat.newRoom',
    async (room) => {
        if (!settings.get('Livechat_webhook_on_start')) {
            return room;
        Severity: Major
        Found in apps/meteor/app/livechat/server/hooks/sendToCRM.ts and 1 other location - About 1 hr to fix
        apps/meteor/app/livechat/server/hooks/sendToCRM.ts on lines 194..205

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        callbacks.add(
    'livechat.chatQueued',
    (room) => {
        if (!settings.get('Livechat_webhook_on_chat_queued')) {
            return room;
        Severity: Major
        Found in apps/meteor/app/livechat/server/hooks/sendToCRM.ts and 1 other location - About 1 hr to fix
        apps/meteor/app/livechat/server/hooks/sendToCRM.ts on lines 168..179

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        export const isOmnichannelNavigationMessage = (message: IMessage): message is IOmnichannelSystemMessage => {
    return message.t === msgNavType;
};
        Severity: Minor
        Found in apps/meteor/app/livechat/server/hooks/sendToCRM.ts and 1 other location - About 30 mins to fix
        apps/meteor/app/livechat/server/hooks/sendToCRM.ts on lines 55..57

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        export const isOmnichannelClosingMessage = (message: IMessage): message is IOmnichannelSystemMessage => {
    return message.t === msgClosingType;
};
        Severity: Minor
        Found in apps/meteor/app/livechat/server/hooks/sendToCRM.ts and 1 other location - About 30 mins to fix
        apps/meteor/app/livechat/server/hooks/sendToCRM.ts on lines 51..53

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status