Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/app/livechat/server/lib/Contacts.ts

Summary

Maintainability
D
3 days
Test Coverage

Function registerContact has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
Open

    async registerContact({
        token,
        name,
        email = '',
        phone,
Severity: Minor
Found in apps/meteor/app/livechat/server/lib/Contacts.ts - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function registerContact has 100 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    async registerContact({
        token,
        name,
        email = '',
        phone,
Severity: Major
Found in apps/meteor/app/livechat/server/lib/Contacts.ts - About 4 hrs to fix

    Function validateCustomFields has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

    export function validateCustomFields(allowedCustomFields: ILivechatCustomField[], customFields: Record<string, string | unknown>) {
    for (const cf of allowedCustomFields) {
        if (!customFields.hasOwnProperty(cf._id)) {
            if (cf.required) {
                throw new Error(i18n.t('error-invalid-custom-field-value', { field: cf.label }));
    Severity: Minor
    Found in apps/meteor/app/livechat/server/lib/Contacts.ts - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function validateCustomFields has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function validateCustomFields(allowedCustomFields: ILivechatCustomField[], customFields: Record<string, string | unknown>) {
    for (const cf of allowedCustomFields) {
        if (!customFields.hasOwnProperty(cf._id)) {
            if (cf.required) {
                throw new Error(i18n.t('error-invalid-custom-field-value', { field: cf.label }));
    Severity: Minor
    Found in apps/meteor/app/livechat/server/lib/Contacts.ts - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  if (cf.regexp) {
                const regex = new RegExp(cf.regexp);
                if (!regex.test(cfValue)) {
                    throw new Error(i18n.t('error-invalid-custom-field-value', { field: cf.label }));
                }
      Severity: Major
      Found in apps/meteor/app/livechat/server/lib/Contacts.ts and 1 other location - About 1 hr to fix
      apps/meteor/app/livechat/server/lib/Contacts.ts on lines 278..283

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 69.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              if (cf.regexp) {
            const regex = new RegExp(cf.regexp);
            if (!regex.test(cfValue)) {
                throw new Error(i18n.t('error-invalid-custom-field-value', { field: cf.label }));
            }
      Severity: Major
      Found in apps/meteor/app/livechat/server/lib/Contacts.ts and 1 other location - About 1 hr to fix
      apps/meteor/app/livechat/server/lib/Contacts.ts on lines 142..147

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 69.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              if (!customFields.hasOwnProperty(cf._id)) {
            if (cf.required) {
                throw new Error(i18n.t('error-invalid-custom-field-value', { field: cf.label }));
            }
            continue;
      Severity: Major
      Found in apps/meteor/app/livechat/server/lib/Contacts.ts and 1 other location - About 1 hr to fix
      apps/meteor/app/livechat/server/lib/Contacts.ts on lines 127..132

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 59.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  if (!customFields.hasOwnProperty(cf._id)) {
                if (cf.required) {
                    throw new Error(i18n.t('error-invalid-custom-field-value', { field: cf.label }));
                }
                continue;
      Severity: Major
      Found in apps/meteor/app/livechat/server/lib/Contacts.ts and 1 other location - About 1 hr to fix
      apps/meteor/app/livechat/server/lib/Contacts.ts on lines 263..268

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 59.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              if (!cfValue || typeof cfValue !== 'string') {
            if (cf.required) {
                throw new Error(i18n.t('error-invalid-custom-field-value', { field: cf.label }));
            }
            continue;
      Severity: Major
      Found in apps/meteor/app/livechat/server/lib/Contacts.ts and 1 other location - About 1 hr to fix
      apps/meteor/app/livechat/server/lib/Contacts.ts on lines 135..140

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  if (!cfValue || typeof cfValue !== 'string') {
                if (cf.required) {
                    throw new Error(i18n.t('error-invalid-custom-field-value', { field: cf.label }));
                }
                continue;
      Severity: Major
      Found in apps/meteor/app/livechat/server/lib/Contacts.ts and 1 other location - About 1 hr to fix
      apps/meteor/app/livechat/server/lib/Contacts.ts on lines 271..276

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      const responses = await Promise.all([
                    Rooms.setFnameById(rid, name),
                    LivechatInquiry.setNameByRoomId(rid, name),
                    Subscriptions.updateDisplayNameByRoomId(rid, name),
                ]);
      Severity: Minor
      Found in apps/meteor/app/livechat/server/lib/Contacts.ts and 1 other location - About 40 mins to fix
      apps/meteor/app/livechat/server/lib/Helper.ts on lines 529..533

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 19 locations. Consider refactoring.
      Open

          const contact = await LivechatContacts.findOneById<Pick<ILivechatContact, '_id'>>(contactId, { projection: { _id: 1 } });
      Severity: Major
      Found in apps/meteor/app/livechat/server/lib/Contacts.ts and 18 other locations - About 30 mins to fix
      apps/meteor/app/api/server/lib/messages.ts on lines 25..25
      apps/meteor/app/api/server/lib/messages.ts on lines 64..64
      apps/meteor/app/authorization/server/methods/addUserToRole.ts on lines 35..35
      apps/meteor/app/authorization/server/methods/removeUserFromRole.ts on lines 35..35
      apps/meteor/app/lib/server/lib/notifyListener.ts on lines 167..169
      apps/meteor/app/lib/server/lib/notifyListener.ts on lines 417..417
      apps/meteor/app/livechat/server/lib/Contacts.ts on lines 295..295
      apps/meteor/app/statistics/server/lib/SAUMonitor.ts on lines 27..27
      apps/meteor/ee/app/livechat-enterprise/server/api/lib/priorities.ts on lines 88..88
      apps/meteor/ee/app/livechat-enterprise/server/hooks/beforeForwardRoomToDepartment.ts on lines 19..21
      apps/meteor/ee/app/livechat-enterprise/server/hooks/onLoadForwardDepartmentRestrictions.ts on lines 13..15
      apps/meteor/ee/server/configuration/videoConference.ts on lines 23..23
      apps/meteor/ee/server/configuration/videoConference.ts on lines 35..35
      apps/meteor/server/modules/core-apps/cloudAnnouncements.module.ts on lines 65..65
      apps/meteor/server/modules/watchers/watchers.module.ts on lines 343..343
      apps/meteor/server/services/banner/service.ts on lines 51..53
      apps/meteor/server/services/team/service.ts on lines 428..428
      apps/meteor/server/services/team/service.ts on lines 714..716

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 19 locations. Consider refactoring.
      Open

          const contactManagerUser = await Users.findOneAgentById<Pick<IUser, '_id'>>(contactManagerUserId, { projection: { _id: 1 } });
      Severity: Major
      Found in apps/meteor/app/livechat/server/lib/Contacts.ts and 18 other locations - About 30 mins to fix
      apps/meteor/app/api/server/lib/messages.ts on lines 25..25
      apps/meteor/app/api/server/lib/messages.ts on lines 64..64
      apps/meteor/app/authorization/server/methods/addUserToRole.ts on lines 35..35
      apps/meteor/app/authorization/server/methods/removeUserFromRole.ts on lines 35..35
      apps/meteor/app/lib/server/lib/notifyListener.ts on lines 167..169
      apps/meteor/app/lib/server/lib/notifyListener.ts on lines 417..417
      apps/meteor/app/livechat/server/lib/Contacts.ts on lines 231..231
      apps/meteor/app/statistics/server/lib/SAUMonitor.ts on lines 27..27
      apps/meteor/ee/app/livechat-enterprise/server/api/lib/priorities.ts on lines 88..88
      apps/meteor/ee/app/livechat-enterprise/server/hooks/beforeForwardRoomToDepartment.ts on lines 19..21
      apps/meteor/ee/app/livechat-enterprise/server/hooks/onLoadForwardDepartmentRestrictions.ts on lines 13..15
      apps/meteor/ee/server/configuration/videoConference.ts on lines 23..23
      apps/meteor/ee/server/configuration/videoConference.ts on lines 35..35
      apps/meteor/server/modules/core-apps/cloudAnnouncements.module.ts on lines 65..65
      apps/meteor/server/modules/watchers/watchers.module.ts on lines 343..343
      apps/meteor/server/services/banner/service.ts on lines 51..53
      apps/meteor/server/services/team/service.ts on lines 428..428
      apps/meteor/server/services/team/service.ts on lines 714..716

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status