Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/app/livechat/server/lib/RoutingManager.ts

Summary

Maintainability
B
6 hrs
Test Coverage

Function takeInquiry has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    async takeInquiry(inquiry, agent, options = { clientAction: false }) {
        check(
            agent,
            Match.ObjectIncluding({
                agentId: String,
Severity: Major
Found in apps/meteor/app/livechat/server/lib/RoutingManager.ts - About 2 hrs to fix

    File RoutingManager.ts has 251 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { Apps, AppEvents } from '@rocket.chat/apps';
import { Message, Omnichannel } from '@rocket.chat/core-services';
import type {
    ILivechatInquiryRecord,
    ILivechatVisitor,
    Severity: Minor
    Found in apps/meteor/app/livechat/server/lib/RoutingManager.ts - About 2 hrs to fix

      Function assignAgent has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          async assignAgent(inquiry, agent) {
        check(
            agent,
            Match.ObjectIncluding({
                agentId: String,
      Severity: Minor
      Found in apps/meteor/app/livechat/server/lib/RoutingManager.ts - About 1 hr to fix

        Function unassignAgent has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            async unassignAgent(inquiry, departmentId, shouldQueue = false) {
        const { rid, department } = inquiry;
        const room = await LivechatRooms.findOneById(rid);

        logger.debug(`Removing assignations of inquiry ${inquiry._id}`);
        Severity: Minor
        Found in apps/meteor/app/livechat/server/lib/RoutingManager.ts - About 1 hr to fix

          Function takeInquiry has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              async takeInquiry(inquiry, agent, options = { clientAction: false }) {
        check(
            agent,
            Match.ObjectIncluding({
                agentId: String,
          Severity: Minor
          Found in apps/meteor/app/livechat/server/lib/RoutingManager.ts - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status