Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/app/livechat/server/methods/searchAgent.ts

Summary

Maintainability
A
1 hr
Test Coverage

Similar blocks of code found in 14 locations. Consider refactoring.
Open

        const user = await Users.findOneByUsernameIgnoringCase<Pick<IUser, 'username' | '_id'>>(username, {
            projection: { _id: 1, username: 1 },
        });
Severity: Major
Found in apps/meteor/app/livechat/server/methods/searchAgent.ts and 13 other locations - About 1 hr to fix
apps/meteor/app/2fa/server/functions/resetTOTP.ts on lines 12..14
apps/meteor/app/livechat/server/lib/Departments.ts on lines 14..16
apps/meteor/ee/app/livechat-enterprise/server/hooks/resumeOnHold.ts on lines 15..17
apps/meteor/ee/app/livechat-enterprise/server/lib/VisitorInactivityMonitor.ts on lines 78..81
apps/meteor/ee/app/livechat-enterprise/server/lib/VisitorInactivityMonitor.ts on lines 155..160
apps/meteor/ee/app/livechat-enterprise/server/methods/resumeOnHold.ts on lines 22..24
apps/meteor/server/modules/watchers/watchers.module.ts on lines 217..219
apps/meteor/server/modules/watchers/watchers.module.ts on lines 227..229
apps/meteor/server/services/team/service.ts on lines 327..327
apps/meteor/server/services/team/service.ts on lines 400..400
apps/meteor/server/services/team/service.ts on lines 525..527
apps/meteor/server/services/team/service.ts on lines 768..770
apps/meteor/app/api/server/v1/im.ts on lines 416..416

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status