Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/app/settings/lib/settings.ts

Summary

Maintainability
B
5 hrs
Test Coverage

Function get has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public get<T extends SettingValue = SettingValue>(
        _id: string | RegExp,
        callback?: SettingCallback,
    ): T | undefined | SettingComposedValue<T>[] | void {
        if (callback != null) {
Severity: Minor
Found in apps/meteor/app/settings/lib/settings.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public get<T extends SettingValue = SettingValue>(
        _id: string | RegExp,
        callback?: SettingCallback,
    ): T | undefined | SettingComposedValue<T>[] | void {
        if (callback != null) {
Severity: Minor
Found in apps/meteor/app/settings/lib/settings.ts - About 1 hr to fix

    Avoid too many return statements within this function.
    Open

                return;
    Severity: Major
    Found in apps/meteor/app/settings/lib/settings.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return Meteor.settings?.[_id];
      Severity: Major
      Found in apps/meteor/app/settings/lib/settings.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return Object.keys(Meteor.settings).reduce((items: SettingComposedValue<T>[], key) => {
                const value = Meteor.settings[key];
                if (_id.test(key)) {
                    items.push({
                        key,
        Severity: Major
        Found in apps/meteor/app/settings/lib/settings.ts - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status