Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/app/ui-message/client/messageBox/createComposerAPI.ts

Summary

Maintainability
F
4 days
Test Coverage

Function createComposerAPI has 275 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const createComposerAPI = (input: HTMLTextAreaElement, storageID: string): ComposerAPI => {
    const triggerEvent = (input: HTMLTextAreaElement, evt: string): void => {
        const event = new Event(evt, { bubbles: true });
        // TODO: Remove this hack for react to trigger onChange
        const tracker = (input as any)._valueTracker;
Severity: Major
Found in apps/meteor/app/ui-message/client/messageBox/createComposerAPI.ts - About 1 day to fix

    Function createComposerAPI has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
    Open

    export const createComposerAPI = (input: HTMLTextAreaElement, storageID: string): ComposerAPI => {
    const triggerEvent = (input: HTMLTextAreaElement, evt: string): void => {
        const event = new Event(evt, { bubbles: true });
        // TODO: Remove this hack for react to trigger onChange
        const tracker = (input as any)._valueTracker;
    Severity: Minor
    Found in apps/meteor/app/ui-message/client/messageBox/createComposerAPI.ts - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File createComposerAPI.ts has 284 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import type { IMessage } from '@rocket.chat/core-typings';
import { Emitter } from '@rocket.chat/emitter';
import { Meteor } from 'meteor/meteor';

import type { ComposerAPI } from '../../../../client/lib/chats/ChatAPI';
    Severity: Minor
    Found in apps/meteor/app/ui-message/client/messageBox/createComposerAPI.ts - About 2 hrs to fix

      Function wrapSelection has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          const wrapSelection = (pattern: string): void => {
        const { selectionEnd = input.value.length, selectionStart = 0 } = input;
        const initText = input.value.slice(0, selectionStart);
        const selectedText = input.value.slice(selectionStart, selectionEnd);
        const finalText = input.value.slice(selectionEnd, input.value.length);
      Severity: Minor
      Found in apps/meteor/app/ui-message/client/messageBox/createComposerAPI.ts - About 1 hr to fix

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            const [isMicrophoneDenied, setIsMicrophoneDenied] = (() => {
        let isMicrophoneDenied = false;

        return [
            {
        Severity: Major
        Found in apps/meteor/app/ui-message/client/messageBox/createComposerAPI.ts and 3 other locations - About 3 hrs to fix
        apps/meteor/app/ui-message/client/messageBox/createComposerAPI.ts on lines 131..144
        apps/meteor/app/ui-message/client/messageBox/createComposerAPI.ts on lines 146..159
        apps/meteor/app/ui-message/client/messageBox/createComposerAPI.ts on lines 161..174

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 95.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            const [recordingVideo, setRecordingVideo] = (() => {
        let recordingVideo = false;

        return [
            {
        Severity: Major
        Found in apps/meteor/app/ui-message/client/messageBox/createComposerAPI.ts and 3 other locations - About 3 hrs to fix
        apps/meteor/app/ui-message/client/messageBox/createComposerAPI.ts on lines 131..144
        apps/meteor/app/ui-message/client/messageBox/createComposerAPI.ts on lines 146..159
        apps/meteor/app/ui-message/client/messageBox/createComposerAPI.ts on lines 176..189

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 95.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            const [editing, setEditing] = (() => {
        let editing = false;

        return [
            {
        Severity: Major
        Found in apps/meteor/app/ui-message/client/messageBox/createComposerAPI.ts and 3 other locations - About 3 hrs to fix
        apps/meteor/app/ui-message/client/messageBox/createComposerAPI.ts on lines 146..159
        apps/meteor/app/ui-message/client/messageBox/createComposerAPI.ts on lines 161..174
        apps/meteor/app/ui-message/client/messageBox/createComposerAPI.ts on lines 176..189

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 95.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            const [recording, setRecordingMode] = (() => {
        let recording = false;

        return [
            {
        Severity: Major
        Found in apps/meteor/app/ui-message/client/messageBox/createComposerAPI.ts and 3 other locations - About 3 hrs to fix
        apps/meteor/app/ui-message/client/messageBox/createComposerAPI.ts on lines 131..144
        apps/meteor/app/ui-message/client/messageBox/createComposerAPI.ts on lines 161..174
        apps/meteor/app/ui-message/client/messageBox/createComposerAPI.ts on lines 176..189

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 95.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    selection?:
                | { readonly start?: number; readonly end?: number }
                | ((previous: { readonly start: number; readonly end: number }) => { readonly start?: number; readonly end?: number });
        Severity: Major
        Found in apps/meteor/app/ui-message/client/messageBox/createComposerAPI.ts and 1 other location - About 1 hr to fix
        apps/meteor/client/lib/chats/ChatAPI.ts on lines 16..18

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 67.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status