Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/app/ui-utils/client/lib/RoomHistoryManager.ts

Summary

Maintainability
C
1 day
Test Coverage

Function getMore has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public async getMore(rid: IRoom['_id'], limit = defaultLimit): Promise<void> {
        const room = this.getRoom(rid);

        if (Tracker.nonreactive(() => room.hasMore.get()) !== true) {
            return;
Severity: Major
Found in apps/meteor/app/ui-utils/client/lib/RoomHistoryManager.ts - About 2 hrs to fix

    Function getMore has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public async getMore(rid: IRoom['_id'], limit = defaultLimit): Promise<void> {
        const room = this.getRoom(rid);

        if (Tracker.nonreactive(() => room.hasMore.get()) !== true) {
            return;
    Severity: Minor
    Found in apps/meteor/app/ui-utils/client/lib/RoomHistoryManager.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getMoreNext has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public async getMoreNext(rid: IRoom['_id'], atBottomRef: MutableRefObject<boolean>) {
        const room = this.getRoom(rid);
        if (Tracker.nonreactive(() => room.hasMoreNext.get()) !== true) {
            return;
        }
    Severity: Minor
    Found in apps/meteor/app/ui-utils/client/lib/RoomHistoryManager.ts - About 1 hr to fix

      Function getMoreNext has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public async getMoreNext(rid: IRoom['_id'], atBottomRef: MutableRefObject<boolean>) {
        const room = this.getRoom(rid);
        if (Tracker.nonreactive(() => room.hasMoreNext.get()) !== true) {
            return;
        }
      Severity: Minor
      Found in apps/meteor/app/ui-utils/client/lib/RoomHistoryManager.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          public isLoading(rid: IRoom['_id']) {
        const room = this.getRoom(rid);
        return room.isLoading.get();
    }
      Severity: Major
      Found in apps/meteor/app/ui-utils/client/lib/RoomHistoryManager.ts and 2 other locations - About 45 mins to fix
      apps/meteor/app/ui-utils/client/lib/RoomHistoryManager.ts on lines 242..245
      apps/meteor/app/ui-utils/client/lib/RoomHistoryManager.ts on lines 247..250

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          public hasMoreNext(rid: IRoom['_id']) {
        const room = this.getRoom(rid);
        return room.hasMoreNext.get();
    }
      Severity: Major
      Found in apps/meteor/app/ui-utils/client/lib/RoomHistoryManager.ts and 2 other locations - About 45 mins to fix
      apps/meteor/app/ui-utils/client/lib/RoomHistoryManager.ts on lines 242..245
      apps/meteor/app/ui-utils/client/lib/RoomHistoryManager.ts on lines 260..263

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          public hasMore(rid: IRoom['_id']) {
        const room = this.getRoom(rid);
        return room.hasMore.get();
    }
      Severity: Major
      Found in apps/meteor/app/ui-utils/client/lib/RoomHistoryManager.ts and 2 other locations - About 45 mins to fix
      apps/meteor/app/ui-utils/client/lib/RoomHistoryManager.ts on lines 247..250
      apps/meteor/app/ui-utils/client/lib/RoomHistoryManager.ts on lines 260..263

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              upsertMessageBulk({ msgs: Array.from(result.messages).filter((msg) => msg.t !== 'command'), subscription });
      Severity: Minor
      Found in apps/meteor/app/ui-utils/client/lib/RoomHistoryManager.ts and 1 other location - About 45 mins to fix
      apps/meteor/app/ui-utils/client/lib/RoomHistoryManager.ts on lines 224..227

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  upsertMessageBulk({
                msgs: Array.from(result.messages).filter((msg) => msg.t !== 'command'),
                subscription,
            });
      Severity: Minor
      Found in apps/meteor/app/ui-utils/client/lib/RoomHistoryManager.ts and 1 other location - About 45 mins to fix
      apps/meteor/app/ui-utils/client/lib/RoomHistoryManager.ts on lines 297..297

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status