Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx

Summary

Maintainability
D
1 day
Test Coverage

Function CreateDiscussion has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

const CreateDiscussion = ({ onClose, defaultParentRoom, parentMessageId, nameSuggestion }: CreateDiscussionProps): ReactElement => {
    const t = useTranslation();

    const {
        formState: { isDirty, isSubmitting, isValidating, errors },
Severity: Minor
Found in apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                    <Field>
                        <FieldLabel htmlFor={topicId}>{t('Topic')}</FieldLabel>
                        <FieldRow>
                            <TextInput id={topicId} aria-describedby={`${topicId}-hint`} {...register('topic')} />
                        </FieldRow>
Severity: Major
Found in apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx and 1 other location - About 5 hrs to fix
apps/meteor/client/sidebar/header/CreateTeam/CreateTeamModal.tsx on lines 198..206

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 137.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                                render={({ field: { name, onChange, value, onBlur } }) => (
                                    <UserAutoCompleteMultiple
                                        id={membersId}
                                        name={name}
                                        onChange={onChange}
Severity: Major
Found in apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx and 1 other location - About 2 hrs to fix
apps/meteor/client/views/account/integrations/AccountIntegrationsPage.tsx on lines 51..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 90.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            <Modal.Header>
                <Modal.Title>{t('Discussion_title')}</Modal.Title>
                <Modal.Close tabIndex={-1} onClick={onClose} />
            </Modal.Header>
Severity: Major
Found in apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx and 1 other location - About 2 hrs to fix
apps/meteor/client/sidebar/header/CreateDirectMessage.tsx on lines 45..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 18 locations. Consider refactoring.
Open

                        {errors.name && (
                            <FieldError aria-live='assertive' id={`${discussionNameId}-error`}>
                                {errors.name.message}
                            </FieldError>
                        )}
Severity: Major
Found in apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx and 17 other locations - About 1 hr to fix
apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx on lines 142..146
apps/meteor/client/sidebar/header/CreateChannel/CreateChannelModal.tsx on lines 233..237
apps/meteor/client/sidebar/header/CreateDirectMessage.tsx on lines 78..82
apps/meteor/client/views/account/profile/AccountProfileForm.tsx on lines 183..187
apps/meteor/client/views/account/security/ChangePassword.tsx on lines 104..108
apps/meteor/client/views/admin/mailer/MailerPage.tsx on lines 95..99
apps/meteor/client/views/admin/mailer/MailerPage.tsx on lines 148..152
apps/meteor/client/views/admin/mailer/MailerPage.tsx on lines 172..176
apps/meteor/ee/client/omnichannel/additionalForms/CustomFieldsAdditionalForm.tsx on lines 93..97
packages/web-ui-registration/src/LoginForm.tsx on lines 174..178
packages/web-ui-registration/src/LoginForm.tsx on lines 196..200
packages/web-ui-registration/src/RegisterForm.tsx on lines 154..158
packages/web-ui-registration/src/RegisterForm.tsx on lines 181..185
packages/web-ui-registration/src/RegisterForm.tsx on lines 204..208
packages/web-ui-registration/src/RegisterForm.tsx on lines 256..260
packages/web-ui-registration/src/RegisterForm.tsx on lines 280..284
packages/web-ui-registration/src/ResetPasswordForm.tsx on lines 73..77

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 18 locations. Consider refactoring.
Open

                        {errors.parentRoom && (
                            <FieldError aria-live='assertive' id={`${parentRoomId}-error`}>
                                {errors.parentRoom.message}
                            </FieldError>
                        )}
Severity: Major
Found in apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx and 17 other locations - About 1 hr to fix
apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx on lines 169..173
apps/meteor/client/sidebar/header/CreateChannel/CreateChannelModal.tsx on lines 233..237
apps/meteor/client/sidebar/header/CreateDirectMessage.tsx on lines 78..82
apps/meteor/client/views/account/profile/AccountProfileForm.tsx on lines 183..187
apps/meteor/client/views/account/security/ChangePassword.tsx on lines 104..108
apps/meteor/client/views/admin/mailer/MailerPage.tsx on lines 95..99
apps/meteor/client/views/admin/mailer/MailerPage.tsx on lines 148..152
apps/meteor/client/views/admin/mailer/MailerPage.tsx on lines 172..176
apps/meteor/ee/client/omnichannel/additionalForms/CustomFieldsAdditionalForm.tsx on lines 93..97
packages/web-ui-registration/src/LoginForm.tsx on lines 174..178
packages/web-ui-registration/src/LoginForm.tsx on lines 196..200
packages/web-ui-registration/src/RegisterForm.tsx on lines 154..158
packages/web-ui-registration/src/RegisterForm.tsx on lines 181..185
packages/web-ui-registration/src/RegisterForm.tsx on lines 204..208
packages/web-ui-registration/src/RegisterForm.tsx on lines 256..260
packages/web-ui-registration/src/RegisterForm.tsx on lines 280..284
packages/web-ui-registration/src/ResetPasswordForm.tsx on lines 73..77

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        <Modal
            data-qa='create-discussion-modal'
            wrapperFunction={(props) => <Box is='form' onSubmit={handleSubmit(handleCreate)} {...props} />}
        >
            <Modal.Header>
Severity: Minor
Found in apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx and 1 other location - About 35 mins to fix
apps/meteor/client/sidebar/header/CreateDirectMessage.tsx on lines 44..95

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status