Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/client/lib/federation/Federation.ts

Summary

Maintainability
C
1 day
Test Coverage

Function actionAllowed has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

export const actionAllowed = (
    room: Partial<IRoom>,
    action: ValueOf<typeof RoomMemberActions>,
    displayingUserId: IUser['_id'],
    userSubscription?: ISubscription,
Severity: Minor
Found in apps/meteor/client/lib/federation/Federation.ts - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function actionAllowed has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const actionAllowed = (
    room: Partial<IRoom>,
    action: ValueOf<typeof RoomMemberActions>,
    displayingUserId: IUser['_id'],
    userSubscription?: ISubscription,
Severity: Minor
Found in apps/meteor/client/lib/federation/Federation.ts - About 1 hr to fix

    Avoid too many return statements within this function.
    Open

                return false;
    Severity: Major
    Found in apps/meteor/client/lib/federation/Federation.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return displayingUserRoomRoles.includes('owner') ? myself : true;
      Severity: Major
      Found in apps/meteor/client/lib/federation/Federation.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                        return myself;
        Severity: Major
        Found in apps/meteor/client/lib/federation/Federation.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return false;
          Severity: Major
          Found in apps/meteor/client/lib/federation/Federation.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return allowedForOwnersOverDefaultUsers;
            Severity: Major
            Found in apps/meteor/client/lib/federation/Federation.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return allowedForModeratorsOverDefaultUsers;
              Severity: Major
              Found in apps/meteor/client/lib/federation/Federation.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return false;
                Severity: Major
                Found in apps/meteor/client/lib/federation/Federation.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              return !displayingUserRoomRoles.includes('owner');
                  Severity: Major
                  Found in apps/meteor/client/lib/federation/Federation.ts - About 30 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    export const actionAllowed = (
    room: Partial<IRoom>,
    action: ValueOf<typeof RoomMemberActions>,
    displayingUserId: IUser['_id'],
    userSubscription?: ISubscription,
                    Severity: Minor
                    Found in apps/meteor/client/lib/federation/Federation.ts and 1 other location - About 35 mins to fix
                    apps/meteor/client/lib/rooms/roomCoordinator.tsx on lines 31..38

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 47.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                    export const isRoomSettingAllowed = (room: Partial<IRoom>, setting: ValueOf<typeof RoomSettingsEnum>): boolean => {
    if (!isRoomFederated(room)) {
        return false;
    }
                    Severity: Minor
                    Found in apps/meteor/client/lib/federation/Federation.ts and 1 other location - About 30 mins to fix
                    apps/meteor/server/services/federation/Federation.ts on lines 70..79

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status