Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.ts

Summary

Maintainability
F
5 days
Test Coverage

File parseMessageTextToAstMarkdown.spec.ts has 515 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import type { IMessage, ITranslatedMessage } from '@rocket.chat/core-typings';
import type { Options, Root } from '@rocket.chat/message-parser';

import { parseMessageAttachments, parseMessageTextToAstMarkdown } from './parseMessageTextToAstMarkdown';
Severity: Major
Found in apps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.ts - About 1 day to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            it('should return correct attachment quote translated parsed md when translate is active', () => {
            const attachmentTranslatedMessage = {
                ...translatedMessage,
                attachments: [
                    {
    Severity: Major
    Found in apps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.ts and 1 other location - About 5 hrs to fix
    apps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.ts on lines 180..219

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 140.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            it('should return correct attachment translated parsed md when translate is active', () => {
            const attachmentTranslatedMessage = {
                ...translatedMessage,
                attachments: [
                    {
    Severity: Major
    Found in apps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.ts and 1 other location - About 5 hrs to fix
    apps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.ts on lines 221..260

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 140.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        const messageParserTokenMessage: Root = [
        {
            type: 'PARAGRAPH',
            value: [
                {
    Severity: Major
    Found in apps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.ts and 2 other locations - About 5 hrs to fix
    apps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.ts on lines 18..63
    apps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.ts on lines 327..372

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 138.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        const messageParserTokenMessage: Root = [
        {
            type: 'PARAGRAPH',
            value: [
                {
    Severity: Major
    Found in apps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.ts and 2 other locations - About 5 hrs to fix
    apps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.ts on lines 18..63
    apps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.ts on lines 65..110

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 138.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        const messageParserTokenMessageWithWrongData: Root = [
        {
            type: 'PARAGRAPH',
            value: [
                {
    Severity: Major
    Found in apps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.ts and 2 other locations - About 5 hrs to fix
    apps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.ts on lines 65..110
    apps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.ts on lines 327..372

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 138.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                it('should return correct attachment text translated parsed md when translate is active', () => {
                const textAttachment = [
                    {
                        ...attachmentMessage[0],
                        text: 'attachment not translated',
    Severity: Major
    Found in apps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.ts and 1 other location - About 4 hrs to fix
    apps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.ts on lines 403..429

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 119.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                it('should return correct attachment description translated parsed md when translate is active', () => {
                const descriptionAttachment = [
                    {
                        ...attachmentMessage[0],
                        description: 'attachment not translated',
    Severity: Major
    Found in apps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.ts and 1 other location - About 4 hrs to fix
    apps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.ts on lines 462..488

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 119.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        const baseMessage: IMessage = {
        ts: date,
        u: {
            _id: 'userId',
            name: 'userName',
    Severity: Major
    Found in apps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.ts and 2 other locations - About 1 hr to fix
    apps/meteor/client/views/room/MessageList/lib/isMessageNewDay.spec.ts on lines 7..19
    apps/meteor/client/views/room/MessageList/lib/isMessageSequential.spec.ts on lines 9..21

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 66.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status