Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/client/lib/rooms/roomCoordinator.tsx

Summary

Maintainability
C
1 day
Test Coverage

Function add has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public add(roomConfig: IRoomTypeClientConfig, directives: Partial<IRoomTypeClientDirectives>): void {
        this.addRoomType(roomConfig, {
            allowRoomSettingChange(_room: Partial<IRoom>, _setting: ValueOf<typeof RoomSettingsEnum>): boolean {
                return true;
            },
Severity: Minor
Found in apps/meteor/client/lib/rooms/roomCoordinator.tsx - About 1 hr to fix

    Function readOnly has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public readOnly(rid: string, user: AtLeast<IUser, 'username'>): boolean {
        const fields = {
            ro: 1,
            t: 1,
            ...(user && { muted: 1, unmuted: 1 }),
    Severity: Minor
    Found in apps/meteor/client/lib/rooms/roomCoordinator.tsx - About 1 hr to fix

      Function readOnly has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          public readOnly(rid: string, user: AtLeast<IUser, 'username'>): boolean {
        const fields = {
            ro: 1,
            t: 1,
            ...(user && { muted: 1, unmuted: 1 }),
      Severity: Minor
      Found in apps/meteor/client/lib/rooms/roomCoordinator.tsx - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

              return false;
      Severity: Major
      Found in apps/meteor/client/lib/rooms/roomCoordinator.tsx - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                        return false;
        Severity: Major
        Found in apps/meteor/client/lib/rooms/roomCoordinator.tsx - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                          return false;
          Severity: Major
          Found in apps/meteor/client/lib/rooms/roomCoordinator.tsx - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return true;
            Severity: Major
            Found in apps/meteor/client/lib/rooms/roomCoordinator.tsx - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return true;
              Severity: Major
              Found in apps/meteor/client/lib/rooms/roomCoordinator.tsx - About 30 mins to fix

                Function validateRoute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    private validateRoute<TRouteName extends RouteName>(route: IRoomTypeRouteConfig<TRouteName>): void {
        const { name, path, link } = route;

        if (typeof name !== 'string' || name.length === 0) {
            throw new Error('The route name must be a string.');
                Severity: Minor
                Found in apps/meteor/client/lib/rooms/roomCoordinator.tsx - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public archived(rid: string): boolean {
        const room = ChatRoom.findOne({ _id: rid }, { fields: { archived: 1 } });
        return Boolean(room?.archived);
    }
                Severity: Minor
                Found in apps/meteor/client/lib/rooms/roomCoordinator.tsx and 1 other location - About 40 mins to fix
                apps/meteor/client/lib/rooms/roomTypes/livechat.ts on lines 64..67

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 49.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if (Array.isArray(room.muted) && room.muted.indexOf(user.username) !== -1) {
            return true;
        }
                Severity: Minor
                Found in apps/meteor/client/lib/rooms/roomCoordinator.tsx and 1 other location - About 40 mins to fix
                apps/meteor/client/lib/rooms/roomCoordinator.tsx on lines 144..146

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            if (Array.isArray(room.unmuted) && room.unmuted.indexOf(user.username) !== -1) {
                return false;
            }
                Severity: Minor
                Found in apps/meteor/client/lib/rooms/roomCoordinator.tsx and 1 other location - About 40 mins to fix
                apps/meteor/client/lib/rooms/roomCoordinator.tsx on lines 139..141

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            allowMemberAction(
                _room: Partial<IRoom>,
                _action: ValueOf<typeof RoomMemberActions>,
                _showingUserId: IUser['_id'],
                _userSubscription?: ISubscription,
                Severity: Minor
                Found in apps/meteor/client/lib/rooms/roomCoordinator.tsx and 1 other location - About 35 mins to fix
                apps/meteor/client/lib/federation/Federation.ts on lines 15..76

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 47.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status