RocketChat/Rocket.Chat

View on GitHub
apps/meteor/client/meteorOverrides/ddpOverREST.ts

Summary

Maintainability
B
4 hrs
Test Coverage

Function withDDPOverREST has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const withDDPOverREST = (_send: (this: Meteor.IMeteorConnection, message: Meteor.IDDPMessage) => void) => {
    return function _sendOverREST(this: Meteor.IMeteorConnection, message: Meteor.IDDPMessage): void {
        if (shouldBypass(message)) {
            return _send.call(this, message);
        }
Severity: Minor
Found in apps/meteor/client/meteorOverrides/ddpOverREST.ts - About 1 hr to fix

    Function _sendOverREST has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        return function _sendOverREST(this: Meteor.IMeteorConnection, message: Meteor.IDDPMessage): void {
            if (shouldBypass(message)) {
                return _send.call(this, message);
            }
    
    
    Severity: Minor
    Found in apps/meteor/client/meteorOverrides/ddpOverREST.ts - About 1 hr to fix

      Function withDDPOverREST has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      const withDDPOverREST = (_send: (this: Meteor.IMeteorConnection, message: Meteor.IDDPMessage) => void) => {
          return function _sendOverREST(this: Meteor.IMeteorConnection, message: Meteor.IDDPMessage): void {
              if (shouldBypass(message)) {
                  return _send.call(this, message);
              }
      Severity: Minor
      Found in apps/meteor/client/meteorOverrides/ddpOverREST.ts - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

          return false;
      Severity: Major
      Found in apps/meteor/client/meteorOverrides/ddpOverREST.ts - About 30 mins to fix

        Function shouldBypass has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        const shouldBypass = ({ msg, method, params }: Meteor.IDDPMessage): boolean => {
            if (msg !== 'method') {
                return true;
            }
        
        
        Severity: Minor
        Found in apps/meteor/client/meteorOverrides/ddpOverREST.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status