RocketChat/Rocket.Chat

View on GitHub
apps/meteor/client/omnichannel/slaPolicies/SlaTable.tsx

Summary

Maintainability
D
1 day
Test Coverage

Function SlaTable has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

const SlaTable = ({ reload }: { reload: MutableRefObject<() => void> }) => {
    const t = useTranslation();
    const router = useRouter();

    const [filter, setFilter] = useState('');
Severity: Minor
Found in apps/meteor/client/omnichannel/slaPolicies/SlaTable.tsx - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    const headers = (
        <>
            <GenericTableHeaderCell key='name' direction={sortDirection} active={sortBy === 'name'} onClick={setSort} sort='name'>
                {t('Name')}
            </GenericTableHeaderCell>
Severity: Major
Found in apps/meteor/client/omnichannel/slaPolicies/SlaTable.tsx and 1 other location - About 1 day to fix
apps/meteor/client/views/omnichannel/managers/ManagersTable.tsx on lines 57..78

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 212.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

            {isSuccess && data?.sla.length === 0 && !queryHasChanged && (
                <GenericNoResults
                    icon='flag'
                    title={t('No_SLA_policies_yet')}
                    description={t('No_SLA_policies_yet_description')}
Severity: Major
Found in apps/meteor/client/omnichannel/slaPolicies/SlaTable.tsx and 3 other locations - About 3 hrs to fix
apps/meteor/client/omnichannel/cannedResponses/CannedResponsesTable.tsx on lines 137..147
apps/meteor/client/omnichannel/tags/TagsTable.tsx on lines 83..93
apps/meteor/client/views/omnichannel/directory/contacts/ContactTable.tsx on lines 124..134

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 96.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 24 locations. Consider refactoring.
Open

            {isLoading && (
                <GenericTable>
                    <GenericTableHeader>{headers}</GenericTableHeader>
                    <GenericTableBody>
                        <GenericTableLoadingRow cols={4} />
Severity: Major
Found in apps/meteor/client/omnichannel/slaPolicies/SlaTable.tsx and 23 other locations - About 1 hr to fix
apps/meteor/client/omnichannel/businessHours/BusinessHoursTable.tsx on lines 51..58
apps/meteor/client/omnichannel/cannedResponses/CannedResponsesTable.tsx on lines 128..135
apps/meteor/client/omnichannel/monitors/MonitorsTable.tsx on lines 148..155
apps/meteor/client/omnichannel/priorities/PrioritiesTable.tsx on lines 38..45
apps/meteor/client/omnichannel/tags/TagsTable.tsx on lines 74..81
apps/meteor/client/views/admin/customEmoji/CustomEmoji.tsx on lines 70..77
apps/meteor/client/views/admin/customSounds/CustomSoundsTable/CustomSoundsTable.tsx on lines 68..75
apps/meteor/client/views/admin/invites/InvitesPage.tsx on lines 94..101
apps/meteor/client/views/admin/oauthApps/OAuthAppsTable.tsx on lines 51..58
apps/meteor/client/views/admin/permissions/UsersInRole/UsersInRoleTable/UsersInRoleTable.tsx on lines 91..98
apps/meteor/client/views/admin/settings/groups/VoipGroupPage/VoipExtensionsPage.tsx on lines 70..77
apps/meteor/client/views/audit/components/AuditLogTable.tsx on lines 63..70
apps/meteor/client/views/directory/tabs/channels/ChannelsTable/ChannelsTable.tsx on lines 100..107
apps/meteor/client/views/directory/tabs/teams/TeamsTable/TeamsTable.tsx on lines 77..84
apps/meteor/client/views/directory/tabs/users/UsersTable/UsersTable.tsx on lines 99..106
apps/meteor/client/views/omnichannel/currentChats/CurrentChatsPage.tsx on lines 331..338
apps/meteor/client/views/omnichannel/customFields/CustomFieldsTable.tsx on lines 79..86
apps/meteor/client/views/omnichannel/departments/DepartmentsTable/DepartmentsTable.tsx on lines 95..102
apps/meteor/client/views/omnichannel/directory/calls/CallTable.tsx on lines 99..106
apps/meteor/client/views/omnichannel/directory/chats/ChatTable.tsx on lines 138..145
apps/meteor/client/views/omnichannel/directory/contacts/ContactTable.tsx on lines 115..122
apps/meteor/client/views/omnichannel/queueList/QueueListTable.tsx on lines 117..124
apps/meteor/client/views/omnichannel/triggers/TriggersTable.tsx on lines 48..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 19 locations. Consider refactoring.
Open

                    <Pagination
                        divider
                        current={current}
                        itemsPerPage={itemsPerPage}
                        count={data?.total || 0}
Severity: Major
Found in apps/meteor/client/omnichannel/slaPolicies/SlaTable.tsx and 18 other locations - About 1 hr to fix
apps/meteor/client/components/deviceManagement/DeviceManagementTable/DeviceManagementTable.tsx on lines 69..77
apps/meteor/client/omnichannel/cannedResponses/CannedResponsesTable.tsx on lines 188..196
apps/meteor/client/omnichannel/monitors/MonitorsTable.tsx on lines 183..191
apps/meteor/client/omnichannel/tags/TagsTable.tsx on lines 118..126
apps/meteor/client/omnichannel/units/UnitsTable.tsx on lines 118..126
apps/meteor/client/views/admin/customEmoji/CustomEmoji.tsx on lines 104..112
apps/meteor/client/views/admin/integrations/IntegrationsTable.tsx on lines 119..127
apps/meteor/client/views/admin/rooms/RoomsTable.tsx on lines 142..150
apps/meteor/client/views/admin/settings/groups/VoipGroupPage/VoipExtensionsPage.tsx on lines 126..134
apps/meteor/client/views/directory/tabs/channels/ChannelsTable/ChannelsTable.tsx on lines 118..126
apps/meteor/client/views/directory/tabs/teams/TeamsTable/TeamsTable.tsx on lines 100..108
apps/meteor/client/views/directory/tabs/users/UsersTable/UsersTable.tsx on lines 124..132
apps/meteor/client/views/omnichannel/agents/AgentsTable/AgentsTable.tsx on lines 105..113
apps/meteor/client/views/omnichannel/departments/DepartmentsTable/DepartmentsTable.tsx on lines 134..142
apps/meteor/client/views/omnichannel/directory/calls/CallTable.tsx on lines 127..135
apps/meteor/client/views/omnichannel/directory/chats/ChatTable.tsx on lines 162..170
apps/meteor/client/views/omnichannel/queueList/QueueListTable.tsx on lines 148..156
apps/meteor/client/views/omnichannel/triggers/TriggersTable.tsx on lines 78..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                                <GenericTableRow key={_id} tabIndex={0} role='link' onClick={onRowClick(_id)} action qa-user-id={_id}>
                                    <GenericTableCell withTruncatedText>{name}</GenericTableCell>
                                    <GenericTableCell withTruncatedText>{description}</GenericTableCell>
                                    <GenericTableCell withTruncatedText>
                                        {dueTimeInMinutes} {t('minutes')}
Severity: Minor
Found in apps/meteor/client/omnichannel/slaPolicies/SlaTable.tsx and 1 other location - About 30 mins to fix
apps/meteor/client/views/omnichannel/customFields/CustomFieldsTable.tsx on lines 106..122

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status