Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/client/providers/CallProvider/CallProvider.tsx

Summary

Maintainability
D
2 days
Test Coverage

File CallProvider.tsx has 421 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import type { IVoipRoom, VoipEventDataSignature, ICallerInfo, ICallDetails, ILivechatVisitor, Serialized } from '@rocket.chat/core-typings';
import {
    VoipClientEvents,
    isVoipEventAgentCalled,
    isVoipEventAgentConnected,
Severity: Minor
Found in apps/meteor/client/providers/CallProvider/CallProvider.tsx - About 6 hrs to fix

    Function CallProvider has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

    export const CallProvider: FC = ({ children }) => {
    const [clientState, setClientState] = useState<'registered' | 'unregistered'>('unregistered');

    const voipEnabled = useSetting('VoIP_Enabled');
    const subscribeToNotifyUser = useStream('notify-user');
    Severity: Minor
    Found in apps/meteor/client/providers/CallProvider/CallProvider.tsx - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function contextValue has 70 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        const contextValue: CallContextValue = useMemo(() => {
        if (!voipEnabled) {
            return {
                enabled: false,
                ready: false,
    Severity: Major
    Found in apps/meteor/client/providers/CallProvider/CallProvider.tsx - About 2 hrs to fix

      Function handleEventReceived has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              const handleEventReceived = async (event: VoipEventDataSignature): Promise<void> => {
            if (isVoipEventAgentCalled(event)) {
                const { data } = event;
                queueAggregator.callRinging({ queuename: data.queue, callerid: data.callerId });
                setQueueName(queueAggregator.getCurrentQueueName());
      Severity: Minor
      Found in apps/meteor/client/providers/CallProvider/CallProvider.tsx - About 1 hr to fix

        Avoid too many return statements within this function.
        Open

                        return;
        Severity: Major
        Found in apps/meteor/client/providers/CallProvider/CallProvider.tsx - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                          return;
          Severity: Major
          Found in apps/meteor/client/providers/CallProvider/CallProvider.tsx - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return {
            outBoundCallsAllowed: hasVoIPEnterpriseLicense, // set to true only if enterprise license is present.
            outBoundCallsEnabled: hasVoIPEnterpriseLicense, // set to true even if enterprise license is not present.
            outBoundCallsEnabledForUser:
                hasVoIPEnterpriseLicense && clientState === 'registered' && !['IN_CALL', 'ON_HOLD'].includes(voipClient.callerInfo.state), // set to true if the user has enterprise license, but is not able to make outbound calls. (busy, or disabled)
            Severity: Major
            Found in apps/meteor/client/providers/CallProvider/CallProvider.tsx - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          if (isVoipEventQueueMemberAdded(event)) {
                const { data } = event;
                queueAggregator.memberAdded({ queuename: data.queue, queuedcalls: data.queuedCalls });
                setQueueName(queueAggregator.getCurrentQueueName());
                setQueueCounter(queueAggregator.getCallWaitingCount());
              Severity: Major
              Found in apps/meteor/client/providers/CallProvider/CallProvider.tsx and 1 other location - About 2 hrs to fix
              apps/meteor/client/providers/CallProvider/CallProvider.tsx on lines 223..229

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 83.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          if (isVoipEventCallAbandoned(event)) {
                const { data } = event;
                queueAggregator.queueAbandoned({ queuename: data.queue, queuedcallafterabandon: data.queuedCallAfterAbandon });
                setQueueName(queueAggregator.getCurrentQueueName());
                setQueueCounter(queueAggregator.getCallWaitingCount());
              Severity: Major
              Found in apps/meteor/client/providers/CallProvider/CallProvider.tsx and 1 other location - About 2 hrs to fix
              apps/meteor/client/providers/CallProvider/CallProvider.tsx on lines 210..216

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 83.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          if (isVoipEventAgentCalled(event)) {
                const { data } = event;
                queueAggregator.callRinging({ queuename: data.queue, callerid: data.callerId });
                setQueueName(queueAggregator.getCurrentQueueName());
                return;
              Severity: Major
              Found in apps/meteor/client/providers/CallProvider/CallProvider.tsx and 1 other location - About 1 hr to fix
              apps/meteor/client/providers/CallProvider/CallProvider.tsx on lines 217..222

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 69.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          if (isVoipEventQueueMemberRemoved(event)) {
                const { data } = event;
                queueAggregator.memberRemoved({ queuename: data.queue, queuedcalls: data.queuedCalls });
                setQueueCounter(queueAggregator.getCallWaitingCount());
                return;
              Severity: Major
              Found in apps/meteor/client/providers/CallProvider/CallProvider.tsx and 1 other location - About 1 hr to fix
              apps/meteor/client/providers/CallProvider/CallProvider.tsx on lines 191..196

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 69.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status