Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/client/sidebar/RoomList/SideBarItemTemplateWithData.tsx

Summary

Maintainability
F
1 wk
Test Coverage

Function SideBarItemTemplateWithData has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

function SideBarItemTemplateWithData({
    room,
    id,
    selected,
    style,
Severity: Minor
Found in apps/meteor/client/sidebar/RoomList/SideBarItemTemplateWithData.tsx - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getMessage has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

const getMessage = (room: IRoom, lastMessage: IMessage | undefined, t: ReturnType<typeof useTranslation>): string | undefined => {
    if (!lastMessage) {
        return t('No_messages_yet');
    }
    if (isVideoConfMessage(lastMessage)) {
Severity: Minor
Found in apps/meteor/client/sidebar/RoomList/SideBarItemTemplateWithData.tsx - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return false;
Severity: Major
Found in apps/meteor/client/sidebar/RoomList/SideBarItemTemplateWithData.tsx - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return false;
    Severity: Major
    Found in apps/meteor/client/sidebar/RoomList/SideBarItemTemplateWithData.tsx - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return true;
      Severity: Major
      Found in apps/meteor/client/sidebar/RoomList/SideBarItemTemplateWithData.tsx - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return false;
        Severity: Major
        Found in apps/meteor/client/sidebar/RoomList/SideBarItemTemplateWithData.tsx - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return `${lastMessage.u.name || lastMessage.u.username}: ${normalizeSidebarMessage(lastMessage, t)}`;
          Severity: Major
          Found in apps/meteor/client/sidebar/RoomList/SideBarItemTemplateWithData.tsx - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return false;
            Severity: Major
            Found in apps/meteor/client/sidebar/RoomList/SideBarItemTemplateWithData.tsx - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return normalizeSidebarMessage(lastMessage, t);
              Severity: Major
              Found in apps/meteor/client/sidebar/RoomList/SideBarItemTemplateWithData.tsx - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return false;
                Severity: Major
                Found in apps/meteor/client/sidebar/RoomList/SideBarItemTemplateWithData.tsx - About 30 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  function SideBarItemTemplateWithData({
    room,
    id,
    selected,
    style,
                  Severity: Major
                  Found in apps/meteor/client/sidebar/RoomList/SideBarItemTemplateWithData.tsx and 1 other location - About 5 days to fix
                  apps/meteor/client/sidebarv2/RoomList/SideBarItemTemplateWithData.tsx on lines 101..218

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 955.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                  export default memo(SideBarItemTemplateWithData, (prevProps, nextProps) => {
    if (keys.some((key) => prevProps[key] !== nextProps[key])) {
        return false;
    }
                  Severity: Major
                  Found in apps/meteor/client/sidebar/RoomList/SideBarItemTemplateWithData.tsx and 1 other location - About 2 days to fix
                  apps/meteor/client/sidebarv2/RoomList/SideBarItemTemplateWithData.tsx on lines 240..277

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 365.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                  type RoomListRowProps = {
    extended: boolean;
    t: ReturnType<typeof useTranslation>;
    SideBarItemTemplate: ComponentType<
        {
                  Severity: Major
                  Found in apps/meteor/client/sidebar/RoomList/SideBarItemTemplateWithData.tsx and 1 other location - About 1 day to fix
                  apps/meteor/client/sidebarv2/RoomList/SideBarItemTemplateWithData.tsx on lines 61..99

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 289.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                  const getMessage = (room: IRoom, lastMessage: IMessage | undefined, t: ReturnType<typeof useTranslation>): string | undefined => {
    if (!lastMessage) {
        return t('No_messages_yet');
    }
    if (isVideoConfMessage(lastMessage)) {
                  Severity: Major
                  Found in apps/meteor/client/sidebar/RoomList/SideBarItemTemplateWithData.tsx and 1 other location - About 1 day to fix
                  apps/meteor/client/sidebarv2/RoomList/SideBarItemTemplateWithData.tsx on lines 18..35

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 226.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                  const getBadgeTitle = (
    userMentions: number,
    threadUnread: number,
    groupMentions: number,
    unread: number,
                  Severity: Major
                  Found in apps/meteor/client/sidebar/RoomList/SideBarItemTemplateWithData.tsx and 1 other location - About 1 day to fix
                  apps/meteor/client/sidebarv2/RoomList/SideBarItemTemplateWithData.tsx on lines 37..59

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 205.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                  function safeDateNotEqualCheck(a: Date | string | undefined, b: Date | string | undefined): boolean {
    if (!a || !b) {
        return a !== b;
    }
    return new Date(a).toISOString() !== new Date(b).toISOString();
                  Severity: Major
                  Found in apps/meteor/client/sidebar/RoomList/SideBarItemTemplateWithData.tsx and 1 other location - About 2 hrs to fix
                  apps/meteor/client/sidebarv2/RoomList/SideBarItemTemplateWithData.tsx on lines 220..225

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 85.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status